search

ChromeGaming / Dot-Box

Dot-Box is a game where players take turns drawing lines between dots to create boxes. The player who completes the most boxes wins. It's a simple yet strategic game enjoyed by people of all ages.
https://chromegaming.github.io/Dot-Box/
MIT License
103 stars 188 forks source link

[Bug]: Music bug in the entire application #614

Closed ayush-t02 closed 2 months ago

ayush-t02 commented 2 months ago

Give a brief about the bug ✍️

Sound on / off is redundant, when you navigate from home to any other page and come back to home page 2 separate music files are being played. when you click on sound off it stops one of them but the other keeps playing

What is the expected behavior? 🤔

one page should be associated with only one sound track and tracks should not leak into other pages

Provide step by step information reproduce the bug 📄

navigate from home to any other page and back to home

Select program in which you are contributing

GSSoC24

Code of Conduct

github-actions[bot] commented 2 months ago

Hey @ayush-t02! 👋

👉 Thanks for opening this issue. We appreciate your contribution and will look into it as soon as possible. 👉 Don’t forget to star our Dot-Box and Follow Us on GitHub 👉 Make sure you join our Discord, we have created separate channels for all projects

MastanSayyad commented 2 months ago

@ayush-t02 it is happening due to two things:

ayush-t02 commented 2 months ago

do you want me to assign this issue to you?

MastanSayyad commented 2 months ago

Yes, assign it! @ayush-t02

github-actions[bot] commented 2 months ago

Thank you for your contribution! If you have any questions or need further assistance, feel free to reach out to us on our Discord server: Discord. We have separate channels for all projects. Happy coding! 🚀

Connect with us on social media:

ayush-t02 commented 2 months ago

@MastanSayyad music state is still the same on my end alongwith the home screen misaligned

MastanSayyad commented 2 months ago

@MastanSayyad music state is still the same on my end alongwith the home screen misaligned

Home screen was misaligned due to PR #619 in index.html I have only made changes in lets go link

MastanSayyad commented 2 months ago

@ayush-t02 Yes I can see it didnt worked out, on my side it was working fine , I have added error handling in console so I will just check whats the issue, and fix it

MastanSayyad commented 2 months ago

one thing i noticed is that the sound is a little faint as compared to the original sound so it might be a problem with the server loading the bg.mp3 @ayush-t02

image

Error handling console displayed this error, So I will try to fix it! as the code is woking fine the only issue is loading the background music

ayush-t02 commented 2 months ago

yup correct

ayush-t02 commented 2 months ago

I reopened the issue to avoid extra work

MastanSayyad commented 2 months ago

Yeah, good idea, if someone have better solution they can also try it!

MastanSayyad commented 2 months ago

@ayush-t02 The issue is solved now so you can close this issue!

ayush-t02 commented 2 months ago

was this issue fixed by you?

ayush-t02 commented 2 months ago

and it still doesn't seem solved on my end

github-actions[bot] commented 2 months ago

Thank you for your contribution! If you have any questions or need further assistance, feel free to reach out to us on our Discord server: Discord. We have separate channels for all projects. Happy coding! 🚀

Connect with us on social media: