search

Chronial / snapraid-runner

Python script for SnapRAID cronjobs
MIT License
302 stars 96 forks source link

Add support for quiet output #22

Closed brettinternet closed 3 years ago

brettinternet commented 5 years ago

This adds an argument -q / --quiet for the ability to add snapraid --quiet argument to scrub and sync commands. this should also make it easier for others to add additional arguments to snapraid_command, such as those without values like the --quiet arg. This feature improves log output for scripted/cron execution.

I welcome feedback.

Chronial commented 3 years ago

Thanks for the PR and sorry for this veeery slow response. I don't think this needs to be an option. Progress output was never meant to appear in the log. I filtered it out early on (3699e080102ca21f657cb510044c788b1d3091b0). But it was added again by mistake by setting universal_newlines when python3 support was added.

The --quiet option is of course a way better way get rid of the progress bar. I think it just wasn't implemented yet when I first wrote this script. I am now setting it, see 8acd9315dd0827cd48415d80302900f42c0af667.

brettinternet commented 3 years ago

Great, thank you! :slightly_smiling_face:

jennso commented 2 years ago

Is there an argument to see the progress output, this is handy in my case, thank you :)