search

ChroniclerCherry / stardew-valley-mods

A collection of my mods for the game Stardew Valley
GNU General Public License v3.0
44 stars 40 forks source link

[STF] Wallpaper and Floors are not valid item types. #43

Open CMAlbrecht opened 3 years ago

CMAlbrecht commented 3 years ago

Wallpaper and Floors appear amongst the possible values of ItemType in the readme, but as of STF 1.0.9 at least, adding Wallpaper or Floors item stocks to either a regular shop or a vanilla shop result in the following messages:

"Wallpaper" is not a valid ItemType. No items from this stock will be added. "Floors" is not a valid ItemType. No items from this stock will be added.

These messages appear to originate from the lines following the ItemsUtil.CheckItemType test at ItemStock.Update, line 73. It seems that neither Wallpapers nor Floors are added as keys of ObjectInfoSource in ItemsUtil.UpdateObjectInfoSource, lines 24-69.

MJA1981 commented 3 years ago

I also recently ran into this issue when trying to add Wallpaper and flooring after coding like this 

    {
      "ItemType": "Wallpaper",
      "ItemIDs": [
        0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,98,99,100,101,102,103,104
      ],
  "Stock": 5,
    },
    {
      "ItemType": "Floors",
      "ItemIDs": [
        0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55
      ],
  "Stock": 5,
    },

Plus I'm guessing that with the way the game stores info for wallpapers and flooring I am probably going to have to set a price for these items instead of using the sell prices from Objectimformation or the other data files as I some times do?

Thank you for looking into this when you have the time, I hope its something your able to fix without to much effort as it seams you intended to implement it anyways.