search

ChroniclerCherry / stardew-valley-mods

A collection of my mods for the game Stardew Valley
GNU General Public License v3.0
44 stars 40 forks source link

Suppress train arrival message during event #65

Closed jennampe-sdv closed 8 months ago

jennampe-sdv commented 3 years ago

By request of Lumisteria (aka Lumina), who is a prominent Content Patcher pack creator, I wrote and tested a very small fix here that checks whether an event is going on in the target area between warping and showing the arrival message. It appears to work well and I don't foresee how it would create any issues/unexpected changes. Let me know if you have any questions! Thanks for this cool mod. :)

P.S. Accidentally created a pull request to myself, then just accepted it, lol. Sorry for the two commits! ;)

ChroniclerCherry commented 3 years ago

Hey, thank you so much for looking into this! Unfortunately I didn't get around to modding this weekend, but hopefully I can get this fix in the next time.

One thing though is that all of my modding source code are in this single directory, just because of how I set things up from when I first started modding. I can not merge in your changes as-is without it deleting all of my other mods.

If you can revert those commits so that the only change is the fix you did, that would be great. Alternatively I can just manually include your fixes to my repo instead, whichever you'd prefer

Pathoschild commented 8 months ago

Merged into develop for the upcoming Train Station 1.1.2. (I rebased the commit to remove the deletions.) Thanks for the help!