search

ChronixDB / chronix.server

The Chronix Server implementation that is based on Apache Solr.
Apache License 2.0
263 stars 29 forks source link

Graphite line format ingester #94

Closed phxql closed 7 years ago

phxql commented 7 years ago

Hi, i've implemented a Graphite line format ingester. I didn't test it yet, just wanted to have some feedback about the general idea.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling a4cd66593ec5dbaca15022507dcb1457da188f8f on phxql:feature/graphite-ingestion into f499c220b73fe08a731b55e0af478ce8b093a7bb on ChronixDB:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling a4cd66593ec5dbaca15022507dcb1457da188f8f on phxql:feature/graphite-ingestion into f499c220b73fe08a731b55e0af478ce8b093a7bb on ChronixDB:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling a4cd66593ec5dbaca15022507dcb1457da188f8f on phxql:feature/graphite-ingestion into f499c220b73fe08a731b55e0af478ce8b093a7bb on ChronixDB:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling a4cd66593ec5dbaca15022507dcb1457da188f8f on phxql:feature/graphite-ingestion into f499c220b73fe08a731b55e0af478ce8b093a7bb on ChronixDB:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 52b4f949f5e9584bbaa586b53254dcda45f7677c on phxql:feature/graphite-ingestion into f499c220b73fe08a731b55e0af478ce8b093a7bb on ChronixDB:master.

FlorianLautenschlager commented 7 years ago

Thx, i will merge this PR.

danielkza commented 7 years ago

Are there any instructions on how to use this? How does it work, considering the Graphite protocol uses plain TCP and not HTTP? I see nothing about accepting new connections on a different port, just adding a new listener in Solr, which means no existing Graphite clients can talk to it.

phxql commented 7 years ago

Hi, at the moment we implemented the Graphite Line Protocol, but on top of HTTP, not TCP. To get this working with a Graphite client, we need a TCP to HTTP proxy. The other way is to modify the code to open an TCP port, but i'm not sure if that works when running in a Solr context. Unfortunately, the Graphite ingester don't work out of the box.

FlorianLautenschlager commented 7 years ago

We can think about to extend the chronix ingester with an TCP port.

phxql commented 7 years ago

Will that work when Solr is running in a cluster?

FlorianLautenschlager commented 7 years ago

Should work :-)

The chronix ingester just ships the data to the Solr master who handles the replication and sharding.