Chrysostomus / hibernator

Script to automate hibenation setup on archlinux based systems
42 stars 8 forks source link

2 Problems #1

Open IgorVian opened 8 years ago

IgorVian commented 8 years ago

Using your very useful script in Manjaro, caused 2 problems: 1) grub file modified like this: GRUB_CMDLINE_LINUX_DEFAULT="quiet splash $(resume_boot_option)" instead of: GRUB_CMDLINE_LINUX_DEFAULT="quiet splash resume=UUID=c5c38daf-e419-4f32-9b94-e1e7edb9f87d resume_offset=1677312" 2) in mkinitcpio.conf not inserted the "resume" word

I attached the original files, so you can test. Files.zip

Chrysostomus commented 8 years ago

Okay, #1 should be easy to troubleshoot, since it seems to be a case of variable not being expanded.

I'll look into these.

Chrysostomus commented 8 years ago

Well, I found a boatload of other problems as well. I think this going to be a rewrite...

Chrysostomus commented 8 years ago

Okay, I think I found the problem with #2...

Chrysostomus commented 8 years ago

Okay, found the cure and fixed a whole lot of other problems. Will be updating soon. Thanks again for this immensely useful bug report!

Chrysostomus commented 8 years ago

Okay, going to get somw sleep. Cannot upload changes yet, because I noticed that grub requires more complex logic for determining the right resume option, depending on whether device mapper names or uuid or partuuid is used.

IgorVian commented 8 years ago

Thanks for your quickly reply. I'm eager to see the changes!

Chrysostomus commented 8 years ago

Okay, I made some changes that should theoretically fix the issue with grub. Can you test it if it works for you?

Chrysostomus commented 8 years ago

Okay, I did some testing and the problem is not yet solved. The sed command that should insert kernel parameters into /etc/default/grub is somehow faulty.

Chrysostomus commented 8 years ago

Okay, I checked again. It works unless there is additional space at the end of kernel parameter line in /etc/default/grub.

Chrysostomus commented 8 years ago

Should be fixed now

ohquero commented 5 years ago

I tried to run this script today but the GRUB_CMDLINE_LINUX_DEFAULT line edit does not work anymore.

Instead of the partition UUID only a whitespace is appended to that line. Could it be a variable expansion problem as already happened?

Here you can find a bash -x log of the script execution: hibernator.log

Chrysostomus commented 5 years ago

Thanks, I'll look into it.