Chrysostomus / manjaro-zsh-config

Zsh configuration package for manjaro
MIT License
124 stars 52 forks source link

Make git section extra space an opt-in feature #45

Closed PillFall closed 1 year ago

PillFall commented 1 year ago

As I mention in a previous PR https://github.com/Chrysostomus/manjaro-zsh-config/pull/34#issuecomment-1472760668, that configuration must be an opt-in config for whoever got this problem.

In neither of my computers using this configuration, I'm experiencing the issue stated in the PR. I'm using Manjaro Gnome, KDE, XFCE and Cinnamon configurations.

I truly believe this must the use of a not prepared font, or wrong setup in the ambiguous width characters.

It is really annoying to keep changing the code manually every time I update the package, as it will always lead to a weird looking misplacement of the last segment separator, like this

image

Instead of the normal looking way

image

This PR includes an opt-in feature to add that extraspace via .zshrc like this:

# Has weird character width
# Example:
#    is not a diamond
HAS_WIDECHARS="true"