ChthonVII / d2r_24ptr2_wereform_calculator

Wereform IAS Calculator for Diablo 2 Resurrected 2.4 PTR2
GNU General Public License v3.0
4 stars 0 forks source link

Whirlwind is being adjusted #7

Open Warren1001 opened 2 years ago

Warren1001 commented 2 years ago

While it's not exactly relevant to your calculator (and you may not be working on it anymore), anyone who saw our previous work may return here to learn about how it works, so I'll continue using this place for new changes.

2.4.3 announced Whirlwind attack speed rework (using all gear IAS):

Changed the logic for determining how often Whirlwind attacks occur. Whirlwind now incorporates Increased Attack Speed (IAS) from all equipment. The frames between each Whirlwind attack are equal to the attack frame of a basic attack for that character (modified by increased attack speed). While dual wielding, the attack frame for each weapon will be averaged (rounding up). Overall, Whirlwind attacks should be at least as fast as they were before. Slower weapons will attack notably faster.

Warren1001 commented 2 years ago

The statlist swap bug still exists and impacts ALL dual wielded sequence skills (Whirlwind, Frenzy, Double Swing, Double Throw, Dragon Claw, Fists of Fire, Blades of Ice, and Claws of Thunder). This means with attack speeds averaged (either by averaging EIAS or by averaging attack frames in Whirlwind's case) the weapon with the highest chance to hit should ALWAYS be glove-side (primary) for these skills.

Correction: statlist swap bug actually does not exist (fixed I suppose), instead I made a bug report on what's happening: https://us.forums.blizzard.com/en/d2r/t/dual-wielded-sequence-skills-only-use-primary-hands-chance-to-hit/137434

Warren1001 commented 1 year ago

i plan to generate more breakpoints (extreme negatives, assassin, dual wield) sometime today or maybe tomorrow, and we can apply that formula and see if it works unanimously. looked up the AF for assassin A1 (can find the info on AB), its 6 as well.

I see your calculator in site"https://warren1001.github.io/IAS_Calculator/", but i think there are some bugs with it. For example, when barb with 1hs weapon and EIAS=-76, increment=256+rounddown(256(-76)/100,0)=256+rounddown(-194.56)=62, and then FPA=rounddown(2567/62,0)=28. But in your calculator the result is 29. There are similar bugs with bb(2hw) and asn, too.

bit of a necro but following up on this, i realize i misunderstood him originally. he's using the alternative formula for wereforms where the denominator is calculated by trun(Animation_Speed + trun(Animation_Speed EIAS / 100), but we decided on the human denominator calculated by trun(Animation_Speed (100 + EIAS) / 100). i'm going with the assumption that ubeo's formula is correct, as i don't feel like testing huang's noted breakpoint.

and something else to note for future readers, ubeo is using floor to truncate, but (iirc) chthonvii and i had concluded that d2r truncates to 0 instead of negative infinity like it was in LOD. in human formulas, it doesn't matter, as the formula for humans don't get into negative values and thus flooring or truncating to 0 have the same value. anywhere else this would be incorrect (wereform formula for example) where negative intermediate values are possible.

i plan to open a new issue in the next coming days testing the changes they made to assassin with claws in the 2.5 ptr.