`From<i64> for i48` is wrong

Chubercik / i48

`i48` provides a 48-bit signed integer type for Rust, filling the gap between `i32` and `i64`. This type may be useful in certain scenarios where 48-bit precision is required but 64 bits would be excessive.

https://crates.io/crates/i48

MIT License

0 stars 0 forks source link

`From<i64> for i48` is wrong #3

Open Vrtgs opened 2 months ago

Vrtgs commented 2 months ago

because not every i64 can be an i48, the correct impl would be with TryFrom<i64> for i48 and TryFrom<i48> for i64

sorry if I critique too much, just trying to help remove footguns