search

Chuchodavids / guide2go

Schedules Direct JSON to XML grabber
MIT License
10 stars 4 forks source link

Images are broken #3

Open tobiasredel opened 1 year ago

tobiasredel commented 1 year ago

SchedulesDirect recently introduced some changes in how images are downloaded (I think). At least i can not manage to get guide2go to include image links into the individual shows - they are all gone from my xml. Any idea if this can be fixed as part of this guide2go fork?

Thank you in advance!!

isaksamsten commented 1 year ago

Hi!

I stumbled upon this issue and thought I could offer an alternative.

I've been using guide2go for some time, but it was never as feature-full as tv_grab_az_sdjson_sqlite which I stopped using when an authentication token was required for downloading icons.

When guide2go stopped downloading images, I took it upon myself to come up with a solution. My solution is a very simple python server that rewrites the xmltv generated by tv_grab_az_sdjson_sqlite and proxies (and caches) event icons.

I've been using it for about two weeks with some minor bugs (now fixed), and it seems pretty functional and stable. Check out the sd_proxy repository to see if it can help you too.

Cheers

iawa2k commented 10 months ago

Is there likely to be a development made for Guide2Go to get this to work? I tried all the Local Images Cache and Proxy Images settings but none seem to work.

nilleiz commented 9 months ago

I was talking to chuchodavids over at reddit. He had no subscription, i donated one, so maybe we can expect a fix for that sooner or later. Just come back here now and then to check for updates. (or here: https://www.reddit.com/r/selfhosted/comments/yd9wd3/comment/jus8rjb/)

UpDryTwist commented 9 months ago

Problem is that SD is sending down height and width as ints, not strings. Straightforward fix. Also added some logging (as long as you have "Show download errors ..." set in the config) to identify future issues. I have some concerns that "size" might also be a problem, but don't have that in any feed I can test at this point.

Pull request is here: #4 (chuchodavids will need to approve the PR to have it incorporated in the main build).

iawa2k commented 8 months ago

This looks like it's been merged but a fresh Docker pull on Stable still doesn't seem to get any program images?

isaksamsten commented 8 months ago

Clone the repository and build the image.

docker build . -t guide2go-dev

should produce an image guide2go-dev that you can use, until the official image is available.

iawa2k commented 8 months ago

Clone the repository and build the image.

docker build . -t guide2go-dev

should produce an image guide2go-dev that you can use, until the official image is available.

You sir are a legend. Many thanks :)

aschulenberg commented 8 months ago

still hasn't been updated on the dockerhub

nilleiz commented 6 months ago

Can anyone confirm this is working now?

iawa2k commented 6 months ago

Can anyone confirm this is working now?

I can, been working perfectly since I built the image in docker from source on the 4th Jan 2024.

nilleiz commented 6 months ago

@iawa2k Does your epg also include the NEW and LIVE icons now, i cant get rid of them when building with docker build . -t guide2go-dev. Cloned the repository with git clone https://github.com/Chuchodavids/guide2go.git . is that correct?

iawa2k commented 6 months ago

@iawa2k Does your epg also include the NEW and LIVE icons now, i cant get rid of them when building with docker build . -t guide2go-dev. Cloned the repository with git clone https://github.com/Chuchodavids/guide2go.git . is that correct?

Yes, I never disabled these as I like to see if it’s a new, live or old/prerecorded episode etc.

I can see you’ve opened a ticket so I’ll let any discussion continue there though. Images downloads are fixed though (the crux of this ticket issue), It’s just remaining open until the merge.

tobiasredel commented 2 months ago

any update on this topic? Can the fix be also implented on docker hub?