Chuckleberry-Finn / game-night

GNU Affero General Public License v3.0
4 stars 3 forks source link

Merging equipped card stack to inventory deck causes stack to break and become stuck #44

Closed CuteMoonGod closed 5 months ago

CuteMoonGod commented 5 months ago

Describe the bug If you merge an equipped stack of cards into an existing deck of your inventory, the stack will correctly be merged into the larger deck, but also consume and destroy the stack item; this causes a number of problems for as long as the game thinks the stack item is still equipped, such as:

To Reproduce

grafik

In regards to the last point (additional cards into the phantom held stack) Proceed as above; then, with the phantom held stack still equipped, draw additional cards into your hand (this appears to only work if you have the deck in your inventory)

Expected behavior When merging a deck, the mod should preferably check if the hand is equipped and either block the action or unequip the held phantom item.

Screenshots If applicable, add screenshots to help explain your problem.

Console logs: Log capturing the error stack console.txt

Additional context Add any other context about the problem here.

Chuckleberry-Finn commented 5 months ago

Thanks, I'll fix this asap. šŸ‘

CuteMoonGod commented 5 months ago

Also found out that the same type of error happens in the "play game" interface if you move a card from your virtual hand to a stack you're holding and searching

Chuckleberry-Finn commented 5 months ago

Just leaving this here for my self: