Issues with initial release of player-shops

[CarlosEZS]

-snip

[Chuckleberry-Finn]

Wallet Issues:

• [x] Wallet values are not updating promptly. 63552d67b146ff0af3c4e2030881312ac06c3a36
• [x] When they do eventually fire they can go into the negatives. 19bfeaaeeee9ed51216e75987c1522be0ec47d8b
• [x] Also impacts trading. 63552d67b146ff0af3c4e2030881312ac06c3a36

No-Wallet Issues:

• [x] Change from shops is random. f7a753b75c0fdcfa8b891a36f16a78beab66f8c4

Shop-Managing:

• [x] Shop is not reflecting the change right away - requires closing and opening the window. c809d8fb8c70ce38240b9f9cc707b53cb34253a3
• [x] ~Category listings does not give back money.~ Better sorting causing issues with display categories. BetterSorting/pull/52
• [ ] ~Needs Confirmation:~ Items with special characters may struggle with the name setting.

Players-Shop:

• [x] There is no way to extract money as a shop-owner. e82daedf3d14619c50c0d05f44ee9d3bed73ac66
• [x] There is no limit to money in the shop - can create infinite money this way. 53e54c106369c71c329556a0ef2be586c64e421a
• [ ] A way to disable cash use in shops all together.

[Chuckleberry-Finn]

Cleaning up the thread for sharing purposes, almost done with the tasks currently set.

[CarlosEZS]

Just want to add an issue with authentic Z. If you make the craft with the money (don't remember the name) you can make infinite money when you craft it back into vanillia money. Don't know if it's a Authentic Z error or Shop and Trader.

[Chuckleberry-Finn]

First pass: https://github.com/ChuckTheSheep/pz-shops/commit/53e54c106369c71c329556a0ef2be586c64e421a

[alf2812]

getting this error code whenever trying to make a new shop. My existing shops still work, but nothing can be added.

attempted index: ownerID of non-table: false function: initialise -- file: shop-window.lua line # 490 | MOD: Shops and Traders function: onBrowse -- file: shop-window.lua line # 1651 | MOD: Shops and Traders function: browseStore -- file: shop-contextMenu.lua line # 11 | MOD: Shops and Traders function: onMouseUp -- file: ISContextMenu.lua line # 90 | Vanilla java.lang.RuntimeException: attempted index: ownerID of non-table: false at se.krka.kahlua.vm.KahluaThread.tableget(KahluaThread.java:1689) at se.krka.kahlua.vm.KahluaThread.luaMainloop(KahluaThread.java:492) at se.krka.kahlua.vm.KahluaThread.call(KahluaThread.java:163) at se.krka.kahlua.vm.KahluaThread.pcall(KahluaThread.java:1980) at se.krka.kahlua.vm.KahluaThread.pcallBoolean(KahluaThread.java:1924) at se.krka.kahlua.integration.LuaCaller.protectedCallBoolean(LuaCaller.java:104) at zombie.ui.UIElement.onMouseUp(UIElement.java:1228) at zombie.ui.UIManager.update(UIManager.java:816) at zombie.GameWindow.logic(GameWindow.java:262) at zombie.core.profiling.AbstractPerformanceProfileProbe.invokeAndMeasure(AbstractPerformanceProfileProbe.java:71) at zombie.GameWindow.frameStep(GameWindow.java:765) at zombie.GameWindow.run_ez(GameWindow.java:667) at zombie.GameWindow.mainThread(GameWindow.java:495) at java.base/java.lang.Thread.run(Unknown Source)

Juggy

[Chuckleberry-Finn]

Thank you, this will be fixed now.

[alf2812]

function: testCanScrap -- file: shop-disassembleProtection.lua line # 4 | MOD: Shops and Traders
function: getCanScrapInfoPanelDesc -- file: shop-disassembleProtection.lua line # 41 | MOD: Shops and Traders
function: getInfoPanelDescription -- file: shop-disassembleProtection.lua line # 58 | MOD: Shops and Traders
function: setInfoPanel -- file: ISMoveableCursor.lua line # 213 | Vanilla
function: isValid -- file: ISMoveableCursor.lua line # 379 | Vanilla
function: DoTileBuilding -- file: ISBuildingObject.lua line # 169 | Vanilla

-snip- java.lang.RuntimeException: attempted index: getModData of non-table: null -snip

Getting this error when trying to pick up certain paintings in the world, but not all of them.

Also when you get a minute (i know youre super busy with the player shop stuff) Would love for you to have a look at the inventory forcibly swapping whenever an item is dragged into it. Not a priority at all tho.

Thanks again chuck

[Chuckleberry-Finn]

Fixed here: 2ba24117ed6acb6e74ae8b53ee33088f6e39a7cf

[Chuckleberry-Finn]

15