search

Chumper / Datatable

This is a laravel 4 package for the server and client side of datatables at http://datatables.net/
https://github.com/Chumper/Datatable
388 stars 153 forks source link

CollectionEngine Ordering #344

Closed bytestream closed 8 years ago

bytestream commented 8 years ago

I'm not sure whether this is intentional but internal ordering on the collection engine makes use of natural ordering (how a human would), see line 267.

Natural ordering alone doesn't work great when using case-sensitive data. See test case.

If you agree that this would be a beneficial change I'll submit a pull request combining SORT_NATURAL with the SORT_FLAG_CASE constant.

timgws commented 8 years ago

@bytestream I agree, however, I think the ordering flags for the collection should be specified as an option, rather then being hard coded.

bytestream commented 8 years ago

@timgws see PR https://github.com/Chumper/Datatable/pull/349

timgws commented 8 years ago

Merged w/ PR #349