search

Chun-Lin / react-select-country-list

This is the country list data format for react-select
MIT License
52 stars 35 forks source link

Simplify the Taiwan name #6

Closed gabrielscabola closed 4 years ago

gabrielscabola commented 4 years ago

Though Taiwan is not internationally recognized as a country, is it certainly not a Chinese province. Taiwan, officially the Republic of China (ROC) has its own Constitution, government and currency. The Taiwanese people are not obligated to report its affairs to the Chinese capital of Beijing; and do not need to obey by mainland Chinese political policies. If you have seen the the Taiwanese leader featured on the media, including CNN and BBC, they refer to her as the “Taiwanese President” and not the “Taiwanese Provincial Governor.” There is no denial Taiwan’s independence in controversial, yet “province” is certainly not the term to classify this island.

Chun-Lin commented 4 years ago

@gabrielscabola thanks for the PR!!

I have published a method called setLabel, so you can easily modify the label name fo Taiwan like below

countries.setLabel('TW', 'Taiwan')

I do realize your concern about it since I'm a Taiwanese. Unfortunately, ISO 3166-1-alpha-2 English country names follow the UN's standard, so I created a method to modify the label name.

Cheers