rule_system_build.py crashes

ButteredGroove commented 5 years ago

Since the last update I'm seeing a crash when running rule_system_build.py:

$ python src/rule_system_build.py
training mode True
reading combined.txt_pre_processed......
Traceback (most recent call last):
  File "src/rule_system_build.py", line 116, in <module>
    n = readFile(filepath,update_freq=True,use_template = True)
  File "src/rule_system_build.py", line 100, in readFile
    handle_sentence(data,n,update_freq,use_template,jamr=False)
  File "src/rule_system_build.py", line 75, in handle_sentence
    fragment_to_node_converter.match(amr,rl ,snt_token,lemma_token,pos_token,lemma_str,jamr=jamr )
  File "/gpfs-volume/AMR_AS_GRAPH_PREDICTION-master/utility/ReCategorization.py", line 605, in match
    self.read_senses(myamr)
  File "/gpfs-volume/AMR_AS_GRAPH_PREDICTION-master/utility/ReCategorization.py", line 481, in read_senses
    out,rel_out,root_index =  myamr.node_value(all=True)
ValueError: too many values to unpack (expected 3)

ChunchuanLv commented 5 years ago

sorry for the bug, I think I know why, I will fix it after EMNLP deadline. Please remind me after Thursday, if I fail to do so.

Chunchuan

On Thu, 16 May 2019 at 23:20, ButteredGroove notifications@github.com wrote:

Since the last update I'm seeing a crash when running rule_system_build.py:

$ python src/rule_system_build.py training mode True reading combined.txt_pre_processed...... Traceback (most recent call last): File "src/rule_system_build.py", line 116, in n = readFile(filepath,update_freq=True,use_template = True) File "src/rule_system_build.py", line 100, in readFile handle_sentence(data,n,update_freq,use_template,jamr=False) File "src/rule_system_build.py", line 75, in handle_sentence fragment_to_node_converter.match(amr,rl ,snt_token,lemma_token,pos_token,lemma_str,jamr=jamr ) File "/gpfs-volume/AMR_AS_GRAPH_PREDICTION-master/utility/ReCategorization.py", line 605, in match self.read_senses(myamr) File "/gpfs-volume/AMR_AS_GRAPH_PREDICTION-master/utility/ReCategorization.py", line 481, in read_senses out,rel_out,root_index = myamr.node_value(all=True) ValueError: too many values to unpack (expected 3)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ChunchuanLv/AMR_AS_GRAPH_PREDICTION/issues/15?email_source=notifications&email_token=AA5TK3IDLLUZUSNKU2JOWSTPVXM4LA5CNFSM4HNQTLJ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GUI7A3A, or mute the thread https://github.com/notifications/unsubscribe-auth/AA5TK3I34AKXL6YNTVT75FDPVXM4LANCNFSM4HNQTLJQ .

TonalidadeHidrica commented 5 years ago

Any improvement for this? I've run into the same issue and it's already Thursday.

ChunchuanLv commented 5 years ago

" File "/gpfs-volume/AMR_AS_GRAPH_PREDICTION-master/utility/ReCategorization.py", line 481, in read_senses

out,rel_out,root_index =  myamr.node_value(all=True)"

Change that line to

 out, rel_out, rel_prefix, root_index =

myamr.node_value(keys=["value", "align"], all=True)

This should fix it.

I am still re-runing for testing, before I push it again.

Chunchuan

On Fri, 24 May 2019 at 16:16, TonalidadeHidrica notifications@github.com wrote:

Any improvement for this? I've run into the same issue and it's already Thursday.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ChunchuanLv/AMR_AS_GRAPH_PREDICTION/issues/15?email_source=notifications&email_token=AA5TK3L3ECYUJNZSCLYZYRDPXABGTA5CNFSM4HNQTLJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWFWCPY#issuecomment-495673663, or mute the thread https://github.com/notifications/unsubscribe-auth/AA5TK3PZ6NJHVHQ4BYTLOZLPXABGTANCNFSM4HNQTLJQ .

TonalidadeHidrica commented 5 years ago

Thank you for the very early reply. Now it started to work without this error.

ButteredGroove commented 5 years ago

It works for me too. Thank you for the fix. I will close.

ChunchuanLv / AMR_AS_GRAPH_PREDICTION

rule_system_build.py crashes #15