search

ChurchCRM / CRM

ChurchCRM is an OpenSource Church CRM & Management Software.
https://ChurchCRM.io
MIT License
618 stars 434 forks source link

USA Addresses not handled correctly in non-USA installations #5986

Open MrClever opened 2 years ago

MrClever commented 2 years ago

On what page in the application did you find this issue?

DirectoryReports.php

On what type of server is this running? Dedicated / Shared hosting? Linux / Windows?

Dedicated system (Debian 11)

What browser (and version) are you running?

What version of PHP is the server running?

7.4.27

What version of SQL Server are you running?

MySQL 5.7.23-23

What version of ChurchCRM are you running?

4.4.5

Description of issue and steps to recreate

When a ChurchCRM is set up to host a non-USA locale and address defaults, any people added that happen to have USA addresses are not handled correctly. Specifically, the USA state is replaced with whatever the ChurchCRM default (local) state is, and the country is omitted.

To recreate

  1. Setup ChurchCRM with non-USA locale and default country/state to be non-USA. For this example I am using: Locale: en_AU Default Country: Australia Default State: NSW
  2. Create a person and associated family with a valid USA address: Screen Shot 2022-02-14 at 12 54 50 pm
  3. Generate a "People Directory" (or mailing label etc) - note state is "NSW" (should be "CA") and country is missing: Screen Shot 2022-02-14 at 12 54 56 pm

Expected result

People Directory should correctly show the USA state and list "United States" as the country.

brianteeman commented 2 years ago

A better way to do this, and for it to work globally, would be to compare the country of the church with the country of the person and not to simply hard code it for the USA

DawoudIO commented 2 years ago

we should open a ticket that removes the US check and compare the system Country.

github-actions[bot] commented 10 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 9 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 8 months ago

This issue was closed because it has been stalled for 15 days with no activity.

respencer commented 4 months ago

Still an issue.

The USA is hard coded in some areas, hence the strange behavior.

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.