ChurchCRM / CRM

ChurchCRM is an OpenSource Church CRM & Management Software.
https://ChurchCRM.io
MIT License
617 stars 434 forks source link

Bug: International phone numbers are shortened #6987

Open respencer opened 4 months ago

respencer commented 4 months ago

Description

A clear and concise description of what the reported bug is:

Steps To Reproduce

📋 Cypress Recorder Results:

cy.visit('http://localhost/v2/dashboard');
cy.xpath('/html/body/div/aside/div/nav/ul/div[1]/a/p/span[1]').click();
cy.url().should('contains', 'http://localhost/PersonEditor.php');
cy.xpath('//*[@id="Gender"]').type('1');
cy.xpath('//*[@id="Gender"]').click();
cy.xpath('//*[@id="FirstName"]').click();
cy.xpath('//*[@id="FirstName"]').type('Jam');
cy.xpath('//*[@id="LastName"]').click();
cy.xpath('//*[@id="LastName"]').type('Roll');
cy.xpath('/html/body/div/div[2]/section[2]/div/form/div[4]/div[2]/div[1]/div[1]/div/input[2]').click();
cy.xpath('/html/body/div/div[2]/section[2]/div/form/div[4]/div[2]/div[1]/div[1]/div/input[1]').type('+3587570321908');
cy.xpath('//*[@id="PersonSaveButton"]').click();
cy.url().should('contains', 'http://localhost/PersonView.php');

The phone number above is fake, but valid for Finland.

Expected behavior

The phone number should not be shortened.

Screenshots and/or logs

If applicable, please include screenshots or share logs to assist in explaining your issue.

📋 Relevant screenshots:

localhost_PersonView php_PersonID=234

📋 Logs:

None.

Debugging Steps

ℹ️ If you need help debugging, please refer to the wiki for guidance: https://github.com/ChurchCRM/CRM/wiki/Logging-and-Diagnostics.

Desktop (please complete the following information):

Additional context

I first noticed the issue when I edited a CSV imported member. Before the edit their full phone number was displayed, after I clicked save the mangled phone number was saved (I had no been making any changes to the phone number).

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.