ChurchCRM / CRM

ChurchCRM is an OpenSource Church CRM & Management Software.
https://ChurchCRM.io
MIT License
622 stars 442 forks source link

Bug: Person editor not showing full content. #7026

Open romdricks opened 5 months ago

romdricks commented 5 months ago

Description

I have 49 persons in the database. 47 of them doesn't show the full content in Person Editor. This occurs when setting the bHidePersonAddress to false in PeopleSetup

Screenshots and/or logs

Screenshot 2024-05-13 162052
DawoudIO commented 5 months ago

Do you have errors in the logs

romdricks commented 5 months ago

Here is the screenshot:

Screenshot 2024-05-14 125844
romdricks commented 5 months ago

[14-May-2024 19:34:12 America/Jamaica] PHP Fatal error: Uncaught TypeError: ChurchCRM\data\Countries::getCountryByName(): Argument #1 ($CountryName) must be of type string, null given, called in /home/.../public_html/churchcrm/Include/StateDropDown.php on line 14 and defined in /home/.../public_html/churchcrm/ChurchCRM/data/Countries.php:297 Stack trace:

0 /home/.../public_html/churchcrm/Include/StateDropDown.php(14): ChurchCRM\data\Countries::getCountryByName()

1 /home/.../public_html/churchcrm/PersonEditor.php(904): require('/home/...')

2 {main}

thrown in /home/.../public_html/churchcrm/ChurchCRM/data/Countries.php on line 297

DAcodedBEAT commented 4 months ago

@romdricks

47 of them doesn't show the full content in Person Editor.

What are you expecting to see?

romdricks commented 4 months ago

@romdricks

47 of them doesn't show the full content in Person Editor.

What are you expecting to see?

Person-Editor

respencer commented 4 months ago

Most of those fields should be hidden when the person is part of a family, and are on the current build.

What does the associated family record look like for those empty fields?

Screenshot 2024-05-17 at 20-44-48 ChurchCRM Person Editor

romdricks commented 4 months ago

Please compare my screenshots and you will notice that the page doesn't fully load; it's cut off.

romdricks commented 4 months ago

@DAcodedBEAT @respencer I was doing some testing and I think i found the issue. I realized setting the bHidePersonAddress to false in PeopleSetup would cause the issue mentioned.

respencer commented 4 months ago

That's expected behavior then. If someone is part of a family the system expects you to use the family address.

romdricks commented 4 months ago

That's expected behavior then. If someone is part of a family the system expects you to use the family address.

Ok. But shouldn't the whole page load with the rest of the content (contact info, membership info, custom fields etc..) and save, save-and-add, and cancel buttons? The footer doesn't load either. The page looks exactly as in the screenshot.

respencer commented 4 months ago

Okay, that would require further investigation.

The thing is I'm currently unable to recreate this issue, so it makes isolating it more difficult. Will make a further attempt to narrow it down.

romdricks commented 4 months ago

okay. thank you.

respencer commented 4 months ago

I originally meant to say "unable" (now edited).

respencer commented 4 months ago

[14-May-2024 19:34:12 America/Jamaica] PHP Fatal error: Uncaught TypeError: ChurchCRM\data\Countries::getCountryByName(): Argument #1 ($CountryName) must be of type string, null given, called in /home/.../public_html/churchcrm/Include/StateDropDown.php on line 14 and defined in /home/.../public_html/churchcrm/ChurchCRM/data/Countries.php:297 Stack trace: #0 /home/.../public_html/churchcrm/Include/StateDropDown.php(14): ChurchCRM\data\Countries::getCountryByName() #1 /home/.../public_html/churchcrm/PersonEditor.php(904): require('/home/...') #2 {main} thrown in /home/.../public_html/churchcrm/ChurchCRM/data/Countries.php on line 297

Out of curiosity, why did you add an address with no country?

romdricks commented 4 months ago

[14-May-2024 19:34:12 America/Jamaica] PHP Fatal error: Uncaught TypeError: ChurchCRM\data\Countries::getCountryByName(): Argument #1 ($CountryName) must be of type string, null given, called in /home/.../public_html/churchcrm/Include/StateDropDown.php on line 14 and defined in /home/.../public_html/churchcrm/ChurchCRM/data/Countries.php:297 Stack trace: #0 /home/.../public_html/churchcrm/Include/StateDropDown.php(14): ChurchCRM\data\Countries::getCountryByName() #1 /home/.../public_html/churchcrm/PersonEditor.php(904): require('/home/...') #2 {main} thrown in /home/.../public_html/churchcrm/ChurchCRM/data/Countries.php on line 297

Out of curiosity, why did you add an address with no country?

Country was added along with zip code, state etc...

respencer commented 4 months ago

[14-May-2024 19:34:12 America/Jamaica] PHP Fatal error: Uncaught TypeError: ChurchCRM\data\Countries::getCountryByName(): Argument #1 ($CountryName) must be of type string, null given, called in /home/.../public_html/churchcrm/Include/StateDropDown.php on line 14 and defined in /home/.../public_html/churchcrm/ChurchCRM/data/Countries.php:297 Stack trace: #0 /home/.../public_html/churchcrm/Include/StateDropDown.php(14): ChurchCRM\data\Countries::getCountryByName() #1 /home/.../public_html/churchcrm/PersonEditor.php(904): require('/home/...') #2 {main} thrown in /home/.../public_html/churchcrm/ChurchCRM/data/Countries.php on line 297

Out of curiosity, why did you add an address with no country?

Country was added along with zip code, state etc...

Okay, that makes no sense then. Null in this context means empty, so the error is that there is no country specified.

Will continue to investigate when I have time.

romdricks commented 4 months ago

[14-May-2024 19:34:12 America/Jamaica] PHP Fatal error: Uncaught TypeError: ChurchCRM\data\Countries::getCountryByName(): Argument #1 ($CountryName) must be of type string, null given, called in /home/.../public_html/churchcrm/Include/StateDropDown.php on line 14 and defined in /home/.../public_html/churchcrm/ChurchCRM/data/Countries.php:297 Stack trace: #0 /home/.../public_html/churchcrm/Include/StateDropDown.php(14): ChurchCRM\data\Countries::getCountryByName() #1 /home/.../public_html/churchcrm/PersonEditor.php(904): require('/home/...') #2 {main} thrown in /home/.../public_html/churchcrm/ChurchCRM/data/Countries.php on line 297

Out of curiosity, why did you add an address with no country?

Country was added along with zip code, state etc...

Okay, that makes no sense then. Null in this context means empty, so the error is that there is no country specified.

Will continue to investigate when I have time.

Ok thank you.

DAcodedBEAT commented 4 months ago

@romdricks is this still an issue on 5.8.0 ?

romdricks commented 4 months ago

@romdricks is this still an issue on 5.8.0 ?

Only when setting the bHidePersonAddress to false in PeopleSetup. I will add it to the description. I am using true now.

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

unknownuserisknown commented 1 month ago

I'm a latecomer here and just noticed this issue: We have several single people in our church with no associated "Family" record. If a given Person is not associated with a Family, then the full contact info for the Person should be visible and editable in the Person editor, right?

github-actions[bot] commented 18 hours ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.