ChurchCRM / CRM

ChurchCRM is an OpenSource Church CRM & Management Software.
https://ChurchCRM.io
MIT License
607 stars 428 forks source link

Drop unused canvass feature #7067

Closed respencer closed 2 weeks ago

respencer commented 3 weeks ago

Description & Issue number it closes

The canvass feature has missing database entries going back 20 years.

I don't see any open or closed issues about it, and a quick poll on Gitter showed no one was using it.

Screenshots (if appropriate)

None. ## How to test the changes? ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] This change requires a documentation update # How Has This Been Tested?

Checklist:

DAcodedBEAT commented 2 weeks ago

@respencer As a fast follow, can you go through the wiki and remove the references to the canvass feature?

respencer commented 2 weeks ago

@respencer As a fast follow, can you go through the wiki and remove the references to the canvass feature?

I'm part way through totally redoing the wiki, I just haven't pushed anything yet.

Will add this to my todo list for the wiki.

DAcodedBEAT commented 2 weeks ago

@respencer As a fast follow, can you go through the wiki and remove the references to the canvass feature?

I'm part way through totally redoing the wiki, I just haven't pushed anything yet.

Will add this to my todo list for the wiki.

Awesome! I'm planning on merging this once the tests are done, so we should remove this soon after to avoid having documentation for a nonexistent feature

DawoudIO commented 2 weeks ago

You need to update the https://github.com/ChurchCRM/CRM/blob/025dbc9d2d9e9ad567ef0bca5ea5461c39273b03/src/mysql/upgrade.json#L372 to support 5.9.0 (I think we yet to move the version of the software) and also the demo/ChurchCRM-Database.sql