search

ChurchCRM / CRM

ChurchCRM is an OpenSource Church CRM & Management Software.
https://ChurchCRM.io
MIT License
636 stars 445 forks source link

Search bar does not work on iOS #821

Closed crossan007 closed 8 years ago

crossan007 commented 8 years ago

Search does not work on iOS Safari.

Works fine on Android / Chrome

DawoudIO commented 8 years ago

same issue as #404

DawoudIO commented 8 years ago

I also did not work on iOS Chrome

crossan007 commented 8 years ago

@DawoudIO I believe that all iOS browsers use the same rendering engine: http://www.howtogeek.com/184283/why-third-party-browsers-will-always-be-inferior-to-safari-on-iphone-and-ipad/

crossan007 commented 8 years ago

It looks like this thread has a working solution (I just tested it on my production): https://github.com/almasaeed2010/AdminLTE/issues/802

Copy this version of fastclick into the skin dir: https://raw.githubusercontent.com/ftlabs/fastclick/569732a7aa5861d428731b8db022b2d55abe1a5a/lib/fastclick.js

I'll make a PR for it now.

crossan007 commented 8 years ago

This issue still exists in the 2.1.8 release.

Somehow the wrong version of fastclick.js was included in the released zip file.

The MD5 of fastclick should be: C87583FE60F2641463DE8FB898FBC332

You can obtain the correct version here: https://raw.githubusercontent.com/ftlabs/fastclick/569732a7aa5861d428731b8db022b2d55abe1a5a/lib/fastclick.js

the MD5 of the broken (released) version is: 6E9D3B0DA74F2A4A7042B494CDAA7C2E

DawoudIO commented 8 years ago

I think we need to download he correct version and have the build-skin.sh script patch it..

crossan007 commented 8 years ago

That is happening in line 34 of build-skin.sh

DawoudIO commented 8 years ago

works in 2.1.10 release