search

ChurchThemes-WP / uplifted-theme

A robust church theme for WordPress.
https://churchthemes.net/themes/uplifted/
0 stars 0 forks source link

Customizer color palette is wonky #121

Closed michaelbeil closed 9 years ago

michaelbeil commented 9 years ago

Footer menu goes white when switching to custom colors. It seems as though the secondary color is remaining the same as the primary color, of the built in color palettes, or background color of the page. footer1 footer2

angela-crist commented 9 years ago

How's this going?

michaelbeil commented 9 years ago

https://secure.helpscout.net/conversation/103067536/4829/

angela-crist commented 9 years ago

@christianc1 Could you take a look at this I think this customer https://secure.helpscout.net/conversation/118197522/5229/ is also having a similar issue with the colors.

christianc1 commented 9 years ago

Fixed in 1.3.4

angela-crist commented 9 years ago

Hey @christianc1 I'm not seeing the secondary color only on the 'give' button. Do we have the secondary color defined of where it should show?

angela-crist commented 9 years ago

Here's a screenshot...ignore the crazy colors http://lift.d.pr/AQSm/2DFLWaEA

christianc1 commented 9 years ago

To put it as simply as I can, the user selects the background color of their choice and the theme generates stylesheets selecting colors that contrast to the background color. For example, if the user selects a dark color as the background, the stylesheet automatically selects white text for easy contrast. The original issue here is that when a user selected a light gray color, the theme generated a white text color which was difficult to read. If we want to explicitly set certain font colors to match explicitly set colors from the customizer, that's a separate issue.

angela-crist commented 9 years ago

Oh I get that. My bad. Sounds like I just need to open a new ticket. I'm trying to understand where I will see the secondary color. http://lift.d.pr/17wNi/GeDAgsTI

christianc1 commented 9 years ago

https://github.com/ChurchThemes-WP/uplifted-theme/blob/3b2004c12a8d579460996cef1524171780da2d0a/assets/sass/colors.scss

cmd+f "$secondary-color"

:)

christianc1 commented 9 years ago

Okay according to the CSS, the following elements use the secondary color: