Closed lygstate closed 1 month ago
OOM具体是简单失败还是直接中断处理这个是二种方案。我不做评价。
但是现在这里返回false并不会导致dll加载失败,任然会继续进行。反而因为你没有调用dllmain,问题可能反而更快不可控。
请注意:只有ATTACH process时返回false才会让dll加载失败。
获取Outlook for Androidhttps://aka.ms/AAb9ysg
From: Yonggang Luo @.> Sent: Friday, June 14, 2024 5:04:42 PM To: Chuyu-Team/YY-Thunks @.> Cc: mingkuang @.>; Comment @.> Subject: Re: [Chuyu-Team/YY-Thunks] Opt 优化 XP下 thread_local 内存分配 (PR #96)
@lygstate commented on this pull request.
In src/Thunks/DllMainCRTStartup.hpphttps://github.com/Chuyu-Team/YY-Thunks/pull/96#discussion_r1639516123:
}
CloseHandle(_hThread);
有道理
― Reply to this email directly, view it on GitHubhttps://github.com/Chuyu-Team/YY-Thunks/pull/96#discussion_r1639516123, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEX7GZJJC43WMPEO4HUHRE3ZHKW2VAVCNFSM6AAAAABIVR3ZC6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMJXHA4DKNBYGY. You are receiving this because you commented.Message ID: @.***>
很高兴你的PR,我现在的代码是值得合并的。但是审查过程中,我发现还有其他TLS的逻辑拥有优化空间,比如DLL彻底不使用TLS时,我们不应该执行任何TLS相关分配逻辑。
考虑到本地修改没有根本性的影响。下次有时间,我把这些TLS问题统一一起处理。希望可以理解。
PR维持开启状态,未来统一解决后再关闭改PR。
Tls堆损Bug #108中已经带入了该修改。
OOM具体是简单失败还是直接中断处理这个是二种方案。我不做评价。
但是现在这里返回false并不会导致dll加载失败,任然会继续进行。反而因为你没有调用dllmain,问题可能反而更快不可控。
请注意:只有ATTACH process时返回false才会让dll加载失败。
获取Outlook for Androidhttps://aka.ms/AAb9ysg
From: Yonggang Luo @.> Sent: Friday, June 14, 2024 5:04:42 PM To: Chuyu-Team/YY-Thunks @.> Cc: mingkuang @.>; Comment @.> Subject: Re: [Chuyu-Team/YY-Thunks] Opt 优化 XP下 thread_local 内存分配 (PR #96)
@lygstate commented on this pull request.
In src/Thunks/DllMainCRTStartup.hpphttps://github.com/Chuyu-Team/YY-Thunks/pull/96#discussion_r1639516123:
有道理
― Reply to this email directly, view it on GitHubhttps://github.com/Chuyu-Team/YY-Thunks/pull/96#discussion_r1639516123, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEX7GZJJC43WMPEO4HUHRE3ZHKW2VAVCNFSM6AAAAABIVR3ZC6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMJXHA4DKNBYGY. You are receiving this because you commented.Message ID: @.***>