Chysn / O_C-HemisphereSuite

Hemisphere Suite is alternate-alternate firmware for Ornament and Crime, featuring a dual-applet framework with dozens of different modular functions.
324 stars 153 forks source link

Captain Midi crashing on fast midi input #49

Closed madskjeldgaard closed 4 years ago

madskjeldgaard commented 4 years ago

Hello First of all thank you for the fantastic work you have done here - Hemisphere is a daunting piece of work and I really love it so much!

I experience an issue with Captain Midi crashing the Teensy on an otherwise perfectly functioning module. I have fairly fast CV signals going into all four CV inputs which are then fed to channels 1-4 as mod data. It works fine for some time but at some point, inevitebly it seems, it crashes the whole Teensy leading to glitches on the screen and the whole thing dead until reboot.

I am running Hemisphere v1.8 on a mini OC with a Teensy 3.2 overclocked to 120 mhz as per the OC instructions.

I hope this information is useful and otherwise let me know if you want more detail. I atttach here a picture of the dead Captain Midi.

Thanks

2

madskjeldgaard commented 4 years ago

Update: This seems to happen only/mostly when pulling up the log display. Or at least that seems to trigger the crash when doing that.

madskjeldgaard commented 4 years ago

aha, okay, even though it doesn't crash with 4 high frequenct/audio rate inputs the menu becomes sluggish and unresponsive

Chysn commented 4 years ago

Hello, and thanks for the report!

Did you install using the hex file from the Release page in GitHub, or via the Arduino IDE?

madskjeldgaard commented 4 years ago

I am not 100% certain but as far as I remember I did install it using the hex file.

On Tue, Feb 11, 2020 at 03:12:29AM -0800, Chysn wrote:

Hello, and thanks for the report!

Did you install using the hex file from the Release page in GitHub, or via the Arduino IDE?

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/Chysn/O_C-HemisphereSuite/issues/49#issuecomment-584585697

-- Best regards Mads Kjeldgaard

Chysn commented 4 years ago

I’m asking because the IDE version is really important for stability reasons. And you mentioned overclocking, which wouldn’t be an issue with the hex file.

I’d say, re-install using the hex file and see if the issue goes away.

https://github.com/Chysn/O_C-HemisphereSuite/releases/

madskjeldgaard commented 4 years ago

I’m asking because the IDE version is really important for stability reasons. And you mentioned overclocking, which wouldn’t be an issue with the hex file.

I’d say, re-install using the hex file and see if the issue goes away.

https://github.com/Chysn/O_C-HemisphereSuite/releases/

Okay thanks, I will try that and report back here with the results.

madskjeldgaard commented 4 years ago

So I tried that now. I realised I was using arduino 1.8.11 and teensyduino 1.5 and I downgraded to the supported versions 1.8.1/1.35 and tried both compiling myself via the IDE and uploading the hex file but all of it leads to the same issue with Captain Midi crashing unfortunately.

I also tried resetting the eeprom but that did not help either.

As I said above, the rest of Hemisphere works as expected, it's just Captain Midi.

I should add that it gets progressively sluggish the more cv inputs I patch with these signals, it starts to slow down from the third cv input for me and then after a while with the fourth plugged in it crashes.

Chysn commented 4 years ago

Ok, thanks for checking that!

I’ll look into this today. It’s four audio rate CV, assigned to four continuous controller messages on different MIDI channels?

madskjeldgaard commented 4 years ago

Thanks for having a look! Yes, Midi Assign is set to Mod for all four channels, the channels are 1-4. Everything else is set to off

Chysn commented 4 years ago

Fixed in 1.8A. This looks like a bug from the O_C framework, in which some integers would not print properly, and caused a buffer overwrite of screen memory, which usually crashes the module. Fixed by moving the log values display a bit out of the way.

madskjeldgaard commented 4 years ago

Well done ! I will test out the fix here

Get Outlook for Android

On Wed, Feb 12, 2020 at 6:03 AM +0100, "Chysn" notifications@github.com wrote:

Fixed in 1.8A. This looks like a bug from the O_C framework, in which some integers would not print properly, and caused a buffer overwrite of screen memory, which usually crashes the module. Fixed by moving the log values display a bit out of the way.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

madskjeldgaard commented 4 years ago

I recompiled from the master branch including the change and it all seems to be working perfectly now. Thanks a lot for fixing this!

Chysn commented 4 years ago

Sure, thanks for the report!

KittenVillage commented 4 years ago

I think I just hit this bug. I'll try to figure out how to compile on my own, I have a feeling I'll run into it again with the setup I'm trying out. (4 channels in, set to note.)

20200309_211037

filefolder commented 4 years ago

i'm also getting this bug FWIW. using the hex file, haven't tried compiling. every time i accidentally pull up the routing info it crashes almost immediately with busy midi traffic.

is there a way to download the updated 1.8A hex somewhere?

Chysn commented 4 years ago

i'm also getting this bug FWIW. using the hex file, haven't tried compiling. every time i accidentally pull up the routing info it crashes almost immediately with busy midi traffic.

is there a way to download the updated 1.8A hex somewhere?

Not yet, but it will be available this week.

filefolder commented 4 years ago

heyyy at the risk of gift-mouth-horse-looking could i say bump or can anyone just post their 1.8A hex in this thread? this bug is absolutely debilitating for me. thanks in advance

Chysn commented 4 years ago

Sure, this is all set. It's in the Assets section of the 1.8 release: https://github.com/Chysn/O_C-HemisphereSuite/releases

Regards, Jason

On Mon, Apr 20, 2020 at 11:28 PM filefolder notifications@github.com wrote:

heyyy at the risk of gift-mouth-horse-looking could i say or can anyone just post their 1.8A hex in this thread? this bug is absolutely debilitating for me. thanks in advance

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Chysn/O_C-HemisphereSuite/issues/49#issuecomment-616930409, or unsubscribe https://github.com/notifications/unsubscribe-auth/AENMQVBWZEVBO5KTVAHU2XTRNUHHPANCNFSM4KS53KOA .

KittenVillage commented 4 years ago

I compiled with a flipped screen and got this error again. Not sure if it's because I pulled the source off the 'releases' page or not. I'll give it go with the source pulled down from the main page and report back in a bit.

KittenVillage commented 4 years ago

Is working fine with flipped screen. The arduino IDE does some caching or something? I finally had to delete the old directory and start fresh to make sure I had the latest version.

Chysn commented 4 years ago

I know that the Arduino IDE does some kind of caching, but I don’t really know how it behaves. I’m glad you got it working.