Closed mannstrane closed 2 years ago
No, the decay can be adjusted with the encoders, but not the attack.
--Jason
On Tue, Feb 25, 2020 at 1:18 PM mannstrane notifications@github.com wrote:
Is there anyway to adjust the attack on the Kick so it doesn't click? I get inconsistency with the Kick causing an audible click on output. It needs the slightest adjustment to keep from clicking at higher gain settings on output.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Chysn/O_C-HemisphereSuite/issues/53?email_source=notifications&email_token=AENMQVDE4KFIOG6NCZJOUFTREVOGDA5CNFSM4K3PNFTKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IQE36GA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AENMQVCEA2ONHM3MVXFZQ4LREVOGDANCNFSM4K3PNFTA .
Thanks for the reply. Is it normal to get a clicking with kick or is it something with my unit?
@mannstrane post a sound clip if possible? I can compare with mine when I get home in a couple of hours.
I guess it is a little on the clicky side.
On Tue, Feb 25, 2020 at 3:24 PM Wray Bowling notifications@github.com wrote:
@mannstrane https://github.com/mannstrane post a sound clip if possible? I can compare with mine when I get home in a couple of hours.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Chysn/O_C-HemisphereSuite/issues/53?email_source=notifications&email_token=AENMQVFPYEIUTMDJCZOKGTDREV46LA5CNFSM4K3PNFTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM5LSBA#issuecomment-591051012, or unsubscribe https://github.com/notifications/unsubscribe-auth/AENMQVH4P3CZCHXCSDF6PY3REV46LANCNFSM4K3PNFTA .
@wraybowling, I will post later tonight. Would be comparable to cutting a waveform at the rise of a transient compared to cutting at the 0 level. Makes me wonder if there is some sort of variable delay with the waveform.
Here is a screenshot of the waveform:
https://imgur.com/a/xEWEjF2
First transient is ok. 2nd transient has a spike along with some after that.
Attaching wav file here: https://we.tl/t-2K3j794894
Has anyone had a chance to see if the results I am getting are software vs a hardware issue affecting my unit?
I have listened to the file you uploaded. I have also been listening to other kick drums on freesound. I have not checked my unit yet but imagine that it's going to sound the same due to the fact that the original O_c isn't meant to really run at audio rates so some clickiness might be just sample rate getting weird. But it begged the question of what kind of kick would sound good at that lower rate. . Might be able to come up with something that strikes a better balance so that the Kick has mostly lower frequencies and the Snare has mostly mid and upper frequencies.
Looking at the source for BootsNCat(s), both sounds are synthesized from a triangle wave and a sawtooth wave. The click is likely coming from when the envelope lines up with a sawtooth peak.
@wraybowling
Did you look at the image I posted above? You can see an inconsistent spike in the waveform. Would be good to know if the drift in envelope timing is software or hardware related. Does everyone get the same result?
I did. That's because the wave is always cycling regardless of the envelope. I don't know the code base well enough yet to know if I'm right in this suggestion... (@Chysn?) But I THINK eg[ch].Cycle(0); would be a hard sync and that would remedy the envelope and audio waves making inconsistent transients.
Edit: Hmm actually it looks like that's already being done. if (Clock(ch, 1)) eg[ch].Start();
and Start() resets the cycle.. Dunno! This is a good excuse for me to try out my brand new oscilloscope when i get home :)
Interesting. Well I am curious to know if the o_C unit I am using is faulty or if this is a micro controller limitation. I was really looking forward to using this firmware for a minimal system with dual function ability. Adding a VCA and Envelope to the signal path after the o_C somewhat ruins the experience this firmware and hardware has to offer with Kick/Snare.
The vector oscillators are not free-running. The trigger to start the vector oscillator also resets it to the beginning of its cycle. If there's variation in the sound from one instance to the next, it's more likely that it's due to variations in the end of the previous instance.
On Thu, Feb 27, 2020 at 1:52 PM Wray Bowling notifications@github.com wrote:
I did. That's because the wave is always cycling regardless of the envelope. I don't know the code base well enough yet to know if I'm right in this suggestion... (@Chysn https://github.com/Chysn?) But I THINK eg[ch].Cycle(0); would be a hard sync and that would remedy the envelope and audio waves making inconsistent transients.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Chysn/O_C-HemisphereSuite/issues/53?email_source=notifications&email_token=AENMQVHRY5ZFOLXJTWNIALTRFADW3A5CNFSM4K3PNFTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFQISI#issuecomment-592118857, or unsubscribe https://github.com/notifications/unsubscribe-auth/AENMQVESQG7BRIU5Y7QOORTRFADW3ANCNFSM4K3PNFTA .
@Chysn So then the record sample I provided previously is by design and identical for all firmware installs for the kick? Is there a possible software remedy to have the kick fixed?
The envelope vector oscillators are reset but the audio rate triangle vector oscillator for the bass drum is not reset so the phase is inconsistent on the trigger.
The envelope vector oscillators are reset but the audio rate triangle vector oscillator for the bass drum is not reset so the phase is inconsistent on the trigger.
Yes, confirmed. That would be the cause. I may try resetting the bass oscillator on the trigger.
That would remedy the issue! Bass drums really need that consistency. The waveform always starts out as mostly envelope and then has tone. For a first method I’d try syncing the tone. If that doesn’t work Maybe a second envelope added to the signal would give it that “kick.”
Thanks again for looking into this everyone. I really love this little app. Looking forward to a possible update.
I'm closing all outstanding issues with the "enhancement" label at this time, as no additional enhancements are planned.
Is there anyway to adjust the attack on the Kick so it doesn't click? I get inconsistency with the Kick causing an audible click on output. It needs the slightest adjustment to keep from clicking at higher gain settings on output.