Bug: Darkest Timeline crashes if Root note set too high

Chysn / O_C-HemisphereSuite

Hemisphere Suite is alternate-alternate firmware for Ornament and Crime, featuring a dual-applet framework with dozens of different modular functions.

324 stars 153 forks source link

Bug: Darkest Timeline crashes if Root note set too high #98

Closed jddinneen closed 2 years ago

jddinneen commented 3 years ago

Hello and thank you for your work. I have found that, in the Darkest Timeline app, changing the root note past the highest value crashes the module (i.e. inoperative, requiring power off to reset). The cause wasn't obvious from a glance at the code but I'm otherwise happy to help troubleshoot. -JDD

nelsonmilum commented 3 years ago

+1 also happens here.

Chysn commented 2 years ago

Pull request approved for 1.9. Thanks!

evgazloy commented 2 years ago

Glad to help. Thank you for your work!