search

CiaraStrawberry / svd-temporal-controlnet

410 stars 31 forks source link

Code in repo not working, outdated? #2

Closed BlakeOne closed 8 months ago

BlakeOne commented 8 months ago

Oops it looks like the code in this repo has gotten out of sync with your working copy...

Here are the issues that I've encountered so far: the motion_bucket_ids were on the wrong device resulting in a runtime error, EulerDiscreteScheduler was being imported improperly resulting in another runtime error, and the number of frames is still somewhere hard coded at 16 it seems...

I can try to PR my minimal fixes in but I wonder if it might be simpler and more comprehensive to upload the new, working code files that you're training with?

Either way thanks for sharing your project, it looks really exciting! :)

BlakeOne commented 8 months ago

Here's a little PR to show which parts I fixed to get it running: https://github.com/CiaraStrawberry/sdv_controlnet/pull/3

Although I'm not sure if there might be other parts that are outdated too?

CiaraStrawberry commented 8 months ago

Oh it's not done yet, my apologies for not specifying in the readme. Since yesterday evening it works on my side but i haven't checked for any specifics of my copy that are distinct from the repo so that is likely contributing, i'll compare your pr against those, thanks for that.

BlakeOne commented 8 months ago

No worries I understand but I guess I'll keep trying to get it working since I'm impatient and can't wait LOL.. So far I haven't been able to get any decent results yet thou so I'll be super interested to see how you've been doing your training. :)

CiaraStrawberry commented 8 months ago

Make sure you train for 20k+ steps at a batch size of like 8 lr 1e-5, It's working for me so far.

combined_with_square_image_new_gif

Gonna announce on twitter tommorow