CidVonHighwind / VirtualBoyGo

VirtualBoy emulator for the oculus go
GNU General Public License v3.0
83 stars 6 forks source link

V1.5 lacks detail of previous releases #22

Closed OzzyHelix closed 10 months ago

OzzyHelix commented 1 year ago

the image on V1.5 is super dark and lacks the detail of previous releases I am not sure why this is the case 76b1fd3ab90126179201327bb8a7436e

OzzyHelix commented 1 year ago

this is the virtualboyquest fork by comparison b37a5f7925cf0de7ff8b94cf017ac09b

lvonasek commented 1 year ago

The main difference between my fork and this repo is that I didn't update OVR SDK (=it is probably still compatible with Oculus Go but I don't have the device to confirm). Using the latest SDK versus the old one could theoretically affect the compatibility with Quest Pro and future headsets.

OzzyHelix commented 1 year ago

I'm using a Quest 2 I just noticed your fork looked fine but the mainline VirtualBoyGo V1.5 had visual issues with yours having more detail so I'm just confused

lvonasek commented 1 year ago

It looks like a wrong colorspace. The details are there, they are just extremely dark.

OzzyHelix commented 1 year ago

any way for me to fix that?

lvonasek commented 1 year ago

I would try something with this: https://developer.oculus.com/documentation/native/android/mobile-colorspace/

Or change the framebuffer format.

OzzyHelix commented 1 year ago

this might have something to do with the SDK change perhaps colorspace is handled differently in 1.50.0?

lvonasek commented 1 year ago

Probably yes, I didn't read the changelogs.

CidVonHighwind commented 10 months ago

Should be fixed now. Sorry that it took so long.