search

Cidaas / cidaas-android-sdk

With this SDK, you can integrate cidaas smoothly and with minimal effort into your android application. It enables you to map the most important user flows for OAuth2 and OIDC compliant authentication. Secure – Fast – And unrivaled Swabian.
https://www.cidaas.com
MIT License
4 stars 5 forks source link

Check for permission first and don't spam the log with unnecessary stacktraces #14

Closed ts-twt closed 4 years ago

ts-twt commented 4 years ago

The SDK constantly tries to access the location, without checking its permissios!

This results to logs beeing constantly flooded with unusful stack traces.

image

This should not happen!!!

Instead you should

  1. only access location if enabled
  2. check permissions before just trying to access location
  3. don't always just log a full stacktrace, a warning like "no location permission granted" would be enough for an SKD like this
Cidaas commented 4 years ago

Hi, Thank you for getting in touch. We are sorry that you are having trouble with the logs. This issue is handled in the latest update 2.0.2

Cidaas commented 4 years ago

This is now resolved. We hope you will download our latest update, and continue. Truly appreciate your note and interest. Thank you!