Cidan / BetterBags

A total replacement AddOn for World of Warcraft bag frames, inspired by AdiBags.
MIT License
86 stars 38 forks source link

[Feature]: Compact option #443

Open Meilinn opened 2 months ago

Meilinn commented 2 months ago

Describe the feature

I would like to have a compact option. The distance between categories is to big. Also the sorting options are not smart enough, I've tried alphabetically or by size, both left big open spaces. Thank you.

Describe the implementation

Have an option in the menu for a more compact design, with less space between categories.

Cidan commented 2 months ago

Can you show me some screenshots of what you mean? Specifically:

The distance between categories is to big.

What do you mean by this? Vertically? Horizontally?

Also the sorting options are not smart enough, I've tried alphabetically or by size, both left big open spaces.

Are you on version .67? Sorting should be extremely compact now in almost all cases.

Any and all screenshots would help here.

Thanks!

Meilinn commented 2 months ago

Hi, here is one screenshot, I can upload more if you need Screenshot_208

Meilinn commented 2 months ago

My version is .67

Meilinn commented 2 months ago

Here are more. What I mean some categories could move to the left so the bag is smaller. Also the distance between categories, vertical and horizontal could be half, so the bag is smaller. My bank cover 66% of my screen. Screenshot_210 Screenshot_209

Cidan commented 2 months ago

The first one can definitely be improved on. I'll take a look at see where I can optimize on some things -- I have a few thoughts here. Remember though, the goal is to keep things in order, top to bottom, which means I will not shift things out of bag order. In your second and third screenshots, I can't logically shift things around while also preserving order.

I'll take a look and see if I can optimize the layout engine even further in some corner cases though. Thanks.

Meilinn commented 2 months ago

Thank you, I used Adibags for 15 years, I switched because it was having many lua errors. I know this addon is very new, so I don't expect to have it all sorted yet. Great work.

13ulbasaur commented 1 month ago

An option to sort things like Adibags to focus on filling in space would be fantastic, honestly. I too have been using Adibags for years, and this has been a major struggle trying to use this addon, both with just it being a bit of an eyesore and because it causes the bag window to go off screen and be inaccessible (as I can't even drag the bag size because the bottom right is gone).

Cidan commented 1 month ago

An option to sort things like Adibags to focus on filling in space would be fantastic, honestly. I too have been using Adibags for years, and this has been a major struggle trying to use this addon, both with just it being a bit of an eyesore and because it causes the bag window to go off screen and be inaccessible (as I can't even drag the bag size because the bottom right is gone).

Can you show me some screenshots of what you mean?

13ulbasaur commented 1 month ago

So here is how it looks from the top of the screen to the bottom, I had to install ElvUI so that it would fix up Blizzard's bizarre scaling after the update. i think it doesn't factor in UI scaling.

https://i.imgur.com/UpOps9o.png

This can happen again with ElvUI installed and UI scaling added, my mouse double clicks sometimes, and trying to adjust the bag frame size also expands it out of the screen. https://i.imgur.com/fVf3FUe.png

(also, making my bag screen wider just makes empty space) https://i.imgur.com/yCnOWPw.png

Cidan commented 1 month ago

Have you tried adding more columns in the settings?