Cidan / BetterBags

A total replacement AddOn for World of Warcraft bag frames, inspired by AdiBags.
MIT License
85 stars 37 forks source link

Lua Error on /rl / login #488

Closed Harsesis89 closed 1 month ago

Harsesis89 commented 1 month ago

Addon Version

v0.1.80

World of Warcraft Version

Retail

Describe the bug

When logging on or /rl the following error comes up:

Message: Interface/AddOns/BetterBags/frames/grid.lua:161: invalid order function for sorting Time: Sat Jul 27 17:09:54 2024 Count: 1 Stack: Interface/AddOns/BetterBags/frames/grid.lua:161: invalid order function for sorting [string "@Interface/AddOns/BetterBags/frames/grid.lua"]:161: in function Sort' [string "@Interface/AddOns/BetterBags/views/gridview.lua"]:247: in functionRender' [string "@Interface/AddOns/BetterBags/frames/bag.lua"]:258: in function Draw' [string "@Interface/AddOns/BetterBags/core/init.lua"]:257: in functioncb' [string "@Interface/AddOns/BetterBags/core/events.lua"]:50: in function <Interface/AddOns/BetterBags/core/events.lua:45>

[string "@Interface/AddOns/ElvUI_Libraries/Core/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:19: in function <...ies/Core/CallbackHandler-1.0/CallbackHandler-1.0.lua:15> [string "@Interface/AddOns/ElvUI_Libraries/Core/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:54: in function `SendMessage' [string "@Interface/AddOns/BetterBags/core/events.lua"]:186: in function <Interface/AddOns/BetterBags/core/events.lua:185>

Locals: self =

{ view =
{ } columns =
{ } sortVertical = true spacing = 4 cells =
{ } maxCellWidth = 2 box = BetterBagsScrollGrid1 { } headers =
{ } cellToColumn =
{ } idToCell =
{ } compactStyle = 0 inner = Frame { } frame = BetterBagsScrollGrid1 { } cellToID =
{ } bar = Frame { } }

After the error, the bag is able open but only an empty frame is shown:

image

If you close the bag and wait a few seconds before opening it again, the bag contents are then shown.

This error occurs since updating to the latest version earlier today. The following modules are installed.

image

Steps to reproduce

  1. Login or /rl
Harsesis89 commented 1 month ago

The root cause seems to be in https://www.curseforge.com/wow/addons/betterbags-gear-first Disabling the plugin makes the error go away. I raised an issue there too.

zeptognome commented 1 month ago

As there is no current plugin API that supports replacing BetterBags internal sorting functions, its up to that author to fix and/or keep up with internal changes. You'll need to wait for a fix from them and/or disable using it at least for now.