Cidana-Developers / Cidana-SVT-AV1

SVT-AV1 Unit Test
Other
0 stars 0 forks source link

quant matrix feature cannot be covered by end to end tests #62

Open Cidana-Zhengwen opened 5 years ago

Cidana-Zhengwen commented 5 years ago

in av1_qm_init(): { // ... if (q == _NUM_QMLEVELS - 1) { picture_control_set_ptr->gqmatrix[q][c][t] = NULL; picture_control_set_ptr->giqmatrix[q][c][t] = NULL; } // ... }

in av1_quantize_inv_quantize_ii(): { // ... const qm_val_t qMatrix = picture_control_set_ptr->parent_pcs_ptr->gqmatrix[_NUM_QMLEVELS - 1][0][transform_size]; const qm_val_t iqMatrix = picture_control_set_ptr->parent_pcs_ptr->giqmatrix[_NUM_QMLEVELS - 1][0][transform_size]; // NOTE: above code specified to use NUM_QM_LEVELS - 1, // so according to av1_qm_init(), qMatrix & iqMatrix must be NULL here, // so, quant matrix feature cannot be covered in end to end tests at all.

// ... qparam.qmatrix = qMatrix; qparam.iqmatrix = iqMatrix; // ... if (xxx) av1_highbd_quantize_b_facade(..., &qparam); else av1_quantize_b_facade_II(..., &qparam); // ... }