Closed Cidree closed 9 months ago
@Cidree did you check the package with devtools::check_win_devel()
? It is required for CRAN submission, so you'll want to do so and add the note to cran_comments.R
.
I checked now, and this was the result:
Dear package maintainer,
this notification has been generated automatically. Your package rpostgis_1.5.0.tar.gz has been built (if working) and checked for Windows. Please check the log files and (if working) the binary package at: https://win-builder.r-project.org/136NExtfs2WQ The files will be removed after roughly 72 hours. Installation time in seconds: 28 Check time in seconds: 252 Status: 2 NOTEs R Under development (unstable) (2023-10-10 r85312 ucrt)
All the best, Uwe Ligges (CRAN maintainer of binary packages for Windows)
I fixed the NOTE about the namechar argument of pgCheckGeom.
El mié, 11 oct 2023 a las 15:07, David Bucklin @.***>) escribió:
@Cidree https://github.com/Cidree did you check the package with devtools::check_win_devel()? It is required for CRAN submission, so you'll want to do so and add the note to cran_comments.R.
— Reply to this email directly, view it on GitHub https://github.com/mablab/rpostgis/pull/31#issuecomment-1757665248, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXCVYC73R6UFGWLGS4FCHTTX62K2DANCNFSM6AAAAAA53ZZTPQ . You are receiving this because you were mentioned.Message ID: @.***>
Great - good to see it recognizes the maintainer change.
Before you submit, make sure to update cran-comments.R
:
R Under development (unstable) (2023-10-10 r85312 ucrt)
to your test environments (or whatever the version is for the final check you run)revdepcheck::revdep_check
check? Is lucas
still using rpostgis
?Other than that, it looks good. I am going to merge this to master
, and I think you could submit once those final updates are addressed!
Update Master to 1.5.0 version