Cilenco / skipTrackLongPressVolume

MIT License
130 stars 14 forks source link

Need Root #6

Open ragavendranbala opened 5 years ago

ragavendranbala commented 5 years ago

Make the app to work on rooted phones. Without asking adb.

indianpoptart commented 5 years ago

I may have gotten it working: https://github.com/indianpoptart/skipTrackLongPressVolume/releases/tag/1.0.1-root

ragavendranbala commented 5 years ago

I have checked the above link and downloaded the release version. But It's not working on my OnePlus 5 Pie

indianpoptart commented 5 years ago

Got it, thanks for checking! I'll see what I can do to fix it. Does it request root? Or does it just show the adb command dialog

indianpoptart commented 5 years ago

I found the issue, patching it and uploading the new APKs

ragavendranbala commented 5 years ago

It asking root permission. Please inform me after uploading the latest apk

ragavendranbala commented 5 years ago

Version 1.0.2 is also not working

ragavendranbala commented 5 years ago

Tried clearing data of the app, now it's not asking root permission from magisk. I revoked permission and checked again. No change. Using Poweramp to test your application

indianpoptart commented 5 years ago

I think you should grant it via Magisk, if you are using that for root. Going to try something new. I'll update you here when I have pushed a new version

indianpoptart commented 5 years ago

I think you should grant it via Magisk, if you are using that for root. Going to try something new. I'll update you here when I have pushed a new version

https://github.com/indianpoptart/skipTrackLongPressVolume/releases/tag/1.0.3

Pushed a new update with 2 root commands. Should hopefully work. If not let me know.

Something to try if it doesn't seem to work Install the apk, open the app and grant root. Force stop the app and clear its data. Relaunch and see if it works.

ragavendranbala commented 5 years ago

At first time it asked root permission, after that, I force stopped the app cleared cache, data and revoked permission from magisk. Then opened again.it doesn't ask for root permission. I think It will activate adb command already, so only it's not asking again

indianpoptart commented 5 years ago

It shouldn't ask again, only once. If you can enable the service then it should have the permission. Does the main service work?

ragavendranbala commented 5 years ago

Checked with Play music and Poweramp . Not working :-(

indianpoptart commented 5 years ago

Do you have a terminal emulator? You can try running this command: pm grant com.cilenco.skiptrack android.permission.SET_VOLUME_KEY_LONG_PRESS_LISTENER

ragavendranbala commented 5 years ago

https://drive.google.com/folderview?id=1eYzDCQA6Sqz1JgugL_exPSsFY5Ato602

Showing this error

Cilenco commented 5 years ago

I will work on this! But I have never coded an app with root access. What is the default library for checking root permissions and execute commands?

NastyaGrifon commented 4 years ago

I will work on this! But I have never coded an app with root access. What is the default library for checking root permissions and execute commands?

There is no default library per se, but this should help: https://github.com/scottyab/rootbeer

indianpoptart commented 4 years ago

You could also use LibSU. I use this in my app for all the root commands needed, as well as checking for root. You can use this command:

Shell.rootAccess()