Global on-off switch, and other suggestions

[khabib227]

1 - I like a lot the new behavior, per tab, of On/Off button, but I think can be good also have a global toggle button, per tab is the most wanted behavior, but sometimes a global behavior still useful.

2 - And when user toggle CL per tab (not in global mode), it can automatically close the CL panel and refresh the tab, this behavior can be default or optional.

3 - Add the feature of the excellent extension "KeepInTab" to CleanLinks. Can be a global and optional setting, or some cleaning action to the . (asterisk.asterisk) rule. I think this is also a kind of link cleaning.

Is just some suggestions to you think about, thanks so much.

[Cimbali]

Hi @khabib227 thanks for your suggestions.

1. [ ] Global on-off switch: I’ll take this under consideration. Is there a specific need for this that’s not covered by either the per-tab toggle or disabling the addon from about:addons ?
2. [x] automatic close: Usually when I click the toggle button I do off / refresh / on. Since there’s a refresh button just next to the on/off button, I can do all this without closing the popup. I would have to reopen the popup to reenable CleanLinks, if it closed automatically. So that’s saving a click, but then needing to do one more click later on. Also the popup can be closed easily with the escape key, so I’m not sure automatically closing the add-on has a huge added value.
3. [x] Forcing same-tab opening: I think that could be an optional functionality. We try to replicate the new-window behaviour now when cleaning links.

[khabib227]

1 - To be honest, I think per tab toggle is the most important behavior, but sometimes we open some site which open links in popups (not new tabs), and we don't want add rules to this site because is a site we don't want use in future, so a global toggle can avoid the need of about:addons which need many clicks. But is a rare use, not essential, just a useful thing for sometimes.

2 - I normally use CL so, if I want disable CL temporally, I open the panel, toggle button, and after I refresh, but to refresh I use a gesture or F5, in this case the panel don't close, because I never use refresh in toolbar I removed it with css. And after I don't re-enable CL in this tab, because I know which in the others tabs CL is already enabled. I my specific case, with auto refresh I can avoid 2 clicks (1 for refresh, 1 to close panel). But I understand after your use case, which I'm a specific user.

3 - I use CL and "KeepInTab" in same time, because I want control tabs opening behavior, I thing the target is a kind of "dirt" on links, much like a redirect, both change the link behavior for something which many times user don't want. I use both plugins together a long time, without any problem I can continue so, I just make this suggestion because, I think this feature is much related with CL objective, but maybe I'm wrong, and because so I can eliminate one plugin and have just one toggle for all link related cleaning processing. We which use many plugins, sometimes we have trouble with some sites, is uBlock, CleanLinks, KeepInTab, Descentralieyes, recently I stoped use of Descentralieyes because of collateral effects. I think in a perfect world, one plugin would do all things, but is not possible, so unify at least related plugins can be great thing, like uBlock today have 3rd party, image and script blocking, this avoid other 3 plugins.

But is just suggestions to you think about anyway. Thanks so much!

[Cimbali]

The same-tab opening already exists but probably doesn’t work properly. It’s called “Follow Target Attribute?” in the options. I’ll put it back in the next version, with a more understandable option text.

[khabib227]

But “Follow Target Attribute?” is just to cleaned links right? Or all links, even links without any redirects or queries? For example the below link can have the target "fixed":

www.example.com/example.htm

[Cimbali]

Ah that might be only for cleaned links… good point yes.

[Cimbali]

Alright same-tab forcing now applies to all links.

[Cimbali]

I think we could do this like uBlock where ctrl + click on the icon switches off globally instead of single tab. With an explanatory tooltip of course.

[khabib227]

thanks so much

[Cimbali]

Actually I’m not sure how a global toggle would interact with tab-toggles.

• What if you toggle CleanLinks off “globally”, and on again? Should it re-enable all tabs that were off individually before?
• What if you enable CleanLinks from a tab while it is “globally” off, should it enable just that tab? Or enabling it globally too, i.e. enable the rest of non-individually-disabled tabs?
• What about new tabs opened when CleanLinks is off “globally” ? Should they be on, or off?
• Should there be a separate display for “globally” off and per-tab off ? I don’t really think so.

This is what I’m thinking so far:

• click always toggle a tab on/off,
• ctrl + click always toggles all tabs on, or all tabs off, regardless of their initial status,
• not sure yet what to do with new tabs in this situation.

[gabri25ele]

I only discovered the extension today, so maybe I'm asking for something already requested (I apologize in case). I had problems on some pages in the visualization of the CAPTCHA (I can't see the button to open the captcha), so I ask if it would be possible to disable the extension for url or domain automatically.