javascript:; links are broken

[birdie-github]

What I see in the log:

null; 
-> javascript:;

[Cimbali]

Can you give an example of where this happens? We should be avoiding most of those links already so I need the exact value of the href to know why it doesn't work. Also which version are you using?

[birdie-github]

Looks like you've already fixed this in version 4.1.5. Thank you!

[birdie-github]

Found another instance where such links get broken and there's nothing in the log:

https://bugzilla.kernel.org/show_bug.cgi?id=205227

When I click "reply" nothing happens.

[Cimbali]

Alright so the bug here is really that it doesn’t appear in the log:

• There is a valid link, #add_comment
• There is a javascript event modifying the behaviour of that link

So CleanLinks prevents the modification on that link, as it should. You can add a rule to allow javascript modifying links, either just for bugzilla.kernel.org or for *.*

[birdie-github]

You can add a rule to allow JavaScript modifying links

Sorry, I've no idea how to do that.

[Cimbali]

From the settings page,

• either select the *.* rule,
• or create a new one
  • click Add rule
  • Put domain bugzilla.kernel.org
  • Leave path empty
• in the “Cleaning Actions“ part, tick allow javascript to modify links
• click Save rule

[birdie-github]

To be honest I frequent at least a dozen of websites which use such links and I'm not a fan of this solution :-( It would be great to have an icon in the CL popup window which allowed to do that automatically.

[Cimbali]

Yes, that’s on its way! See https://github.com/Cimbali/CleanLinks/issues/104#issuecomment-612649837