Breaks doxygen search

[Ede123]

Maybe I'm too stupid, but I can't seem to manage to properly whitelist the following:

• Visit https://inkscape.gitlab.io/inkscape/doxygen/index.html
• Click into the search field to the upper right
• Enter "pathvector":
  
• Click on Geom::PathVector:
  
• Result: Page opens in the tiny frame of the search box instead of the actual iframe target (_parent).

I've set a whitelist rule (see below), but it does not seem to work. Disabling the CleanLinks extensions completely fixes the issue however.

[Cimbali]

The protocol is not needed in the URL matching. That means just inkscape.gitlab.io not https://inkscape.gitlab.io.

Maybe we can detect it in the future and either ignore it or setup a specific error message.

[Ede123]

Yep, I realized that just after posting the issue (would be nice if there was something to catch this; I assume this would break subdomain matching and protocol changes or would it even break altogether?).

However, even after dropping the protocol, the whitelist rule still does not solve the issue for me. Could you make it work on your end? (The URL is publicly reachable, so you can cross-check from your end if the error is in front or behind the display on my end ;-) ).

[Cimbali]

Interesting, this seems to come from the target="_parent" in the links. In the Clean Links preferences(*) you should tick the box “Allow links to different tabs (target attribute)”.
Maybe we could also investigate allowing _parent but not _blank or more fine-grain options like that.

(*) so not the rules page, but the “Preferences” tab after clicking the add-on in the about:addons page. You can also get there by the gear icon at the bottom of the Clean Links popup.

[Ede123]

Thanks, that did the trick (even without a whitelist entry).

What's the purpose of this preference? Usually it makes sense if people use target="_blank" and obviously even more so if the target attribute is used for iframe navigation like in this case, so even if you'd make it more fine-grained, I'd likely keep it set to allow all of them.

[Cimbali]

I don't use that option personally, but it's used to enforce single-tab browsing. I think it's one of those legacy features, like catching text links, that a few users still use.

IMHO nowadays Firefox does a good job of forcing _blank targets into tabs etc. rather than creating new windows, and possibly this feature is also less misused than a couple of years ago (or I stopped visiting sites that abuse it).

Anyways I just checked and this option is off on fresh installs, so I don't think it should be too harmful.