Cimbali / CleanLinks

Converts obfuscated/nested links to genuine clean links.
https://addons.mozilla.org/en-GB/firefox/addon/clean-links-webext/
Mozilla Public License 2.0
76 stars 2 forks source link

[Bug] find_click_target doesn't handle href if null #156

Closed OdinVex closed 1 year ago

OdinVex commented 1 year ago

Some websites I've come across cause ./inject.js to throw an error in the find_click_target code block, specifically in its attempt to access href. Sometimes it is null. It's uncommon to find a site with it set to null, I've only found it on a few and only in logged-in sessions. I addressed it by checking for href === null and simply returning node.

Cimbali commented 1 year ago

Thanks for suggesting!