small improvements for the log, popup, and whitelist

Cimbali / CleanLinks

Converts obfuscated/nested links to genuine clean links.

https://addons.mozilla.org/en-GB/firefox/addon/clean-links-webext/

Mozilla Public License 2.0

76 stars 2 forks source link

small improvements for the log, popup, and whitelist #19

Closed alekksander closed 6 years ago

alekksander commented 6 years ago

just a bunch of ideas:

whitelist:

[x] if domain is already white listed prevent from creating duplicates

popup:

[x] it's size is too big, does it really has to be that big? top info if necessary could be ¼ of it's size, leaving more for the log. no point of such big font too i guess.
[x] it doesn't scale right. on attachment you can see i can scroll the popup ifself (about 5px)
[x] signify clearly when link tracking is disabled (e.g. grey out list)
[x] clear list button as suggested by jawz101

log:

[x] option to view cleaned links per ~~currently viewed domain~~ tab – not all work it has done so far. switch could be in settings, or on the opposite site of „Whitelist Selection button”

Cimbali commented 6 years ago

You mean when a domain is whitelisted, remove all the items in the list with that domain? Because there shouldn't be new ones any way.

alekksander commented 6 years ago

i've clicked 3 last entries from the screen shot in previous post and what i get is: clog as You can see collector.githubapp.com is added three times.

Cimbali commented 6 years ago

Done part one. I'll try to get around to making the popup nicer, and filter the list by the current tab.

I think that makes more sense than current domain, in case some other/sub domain makes a request (through an iframe or whatnot).

jawz101 commented 6 years ago

Or at least a clear button on the log. As I browse around it accrues a laundry list of cleaned links. When I have an issue that needs whitelisting I have to sift through a bunch of old sites' links cleaned and it's a bit more confusing when I can't just clear out the log when needed.

But the option to show just the current tab would be better.

Cimbali commented 6 years ago

Any feedback/suggestions on the current popup's appearance? @alekksander @jawz101

alekksander commented 6 years ago

„Clear List” doesn't clear it until tabs are switched.

In general it's looking better. if You are asking for suggestions, here is mine to consider: screenshot_20180726_101059 (sorry for ugly sketch)

Cimbali commented 6 years ago

@alekksander @jawz101 Care to try out the looks of the latest commit?

alekksander commented 6 years ago

i don't want to be the one that seems ungrateful and complains all the time, but if i had skills and free time i'd: →fix it's width (when list is empty it's nice and small, when list contains something it gets too wide. perhaps cut it half?) →shrink logo a bit, and leave about ⅔ of it's current size →title and logo missing that 5px margins, that icon buttons has

thank You for Your work so far.

Cimbali commented 6 years ago

Don't worry about it! I'm happy to get feedback, as I don't have strong opinions on the appearance anyway. Here's another update.