CleanLinks is stubborn – doesn't whitelist

Cimbali / CleanLinks

Converts obfuscated/nested links to genuine clean links.

https://addons.mozilla.org/en-GB/firefox/addon/clean-links-webext/

Mozilla Public License 2.0

76 stars 2 forks source link

CleanLinks is stubborn – doesn't whitelist #23

Closed alekksander closed 6 years ago

alekksander commented 6 years ago

go imgops.com and paste:

https://upload.wikimedia.org/wikipedia/commons/d/db/East_Berlin_Death_Strip_seen_from_Axel_Springer_Building_1984.jpg

press start

CleanLinks kicks in and redirects to direct img url.

go back and whitelist proper action

try again and see whitelist being ignored (?) adding imgops.com to whitelist manually is a walk–around

Cimbali commented 6 years ago

It works fine for we with CleanLinks 3.0.2 on ff 60.0. Can you try after whitelisting, if it didn't work :

see if the domain appears in the list in the add-on preferences
reload (F5) the page that causes the redirection

Also what's your setup?

alekksander commented 6 years ago

it does not appear in the list in the add-n preferences (therefore f5 doesn't help) this is reproducible under linux (ubuntu 16.04 based system) fx 59.0.1 and nightly with CL 3.0.2

alekksander commented 6 years ago

i think i found next bug that relates to this issue.

go to: https://www.youtube.com/user/NiszowaTV/videos?disable_polymer=1

and try to see thumbnails. whitelisting youtube.com, and i.ytimg.com doesn't seem to does the trick, it still filters i.ytimg.com content (as popup indicates).

so actually it does whitelist it, but whitelist content remains ignored

Cimbali commented 6 years ago

There were a bunch of problems in the last update:

Parameters were cleaned but not per domain, so this was not ideal and caused some sites to fail loading for perfectly valid URIs.
Some links were added to the cleaning history without having been modified, simply due to URL encoding differences. I've reverted to a previous version, and will re-implement these features differently later.