Cimbali / CleanLinks

Converts obfuscated/nested links to genuine clean links.
https://addons.mozilla.org/en-GB/firefox/addon/clean-links-webext/
Mozilla Public License 2.0
76 stars 2 forks source link

all settings fields are now empty and cannot be edited...parsing bug #47

Closed FredThompsonII closed 6 years ago

FredThompsonII commented 6 years ago

Adding |?Expires to the end of the default "Skip Links matching with:" field will render all fields unviewable and uneditable.

I'm using Win FF 56.0.2 Nightly.

I added that exception because Clean Links was scrubbing time-limited media links and this addition should fix the filtering, however it broke the display.

So, how can this be fixed?

Cimbali commented 6 years ago

It's probably a bug parsing the regex (the question mark should be escaped).

We should catch the error and display it cleanly instead of saving the erroneous regex and crashing everything.

Does the reset button at the bottom of the preferences page still work? Otherwise you probably need to uninstall / reinstall the add-on to fix it. After I manage to get a fix out we shouldn't need such a workaround anymore.

Cimbali commented 6 years ago

@FredThompsonII If you haven't reset the preferences yet, you can update the add-on. That will fix the preferences that can not be edited.

Then, to add your exception back in, add |\?Expires