search

Cimbali / CleanLinks

Converts obfuscated/nested links to genuine clean links.
https://addons.mozilla.org/en-GB/firefox/addon/clean-links-webext/
Mozilla Public License 2.0
76 stars 2 forks source link

CleanLinks alters Facebook open in new tab/window behaviour #61

Closed wyaqoob closed 4 years ago

wyaqoob commented 5 years ago

Hi, fantastic extension. I've noticed that CleanLinks alters FB's current open in new tab behaviour, i.e. clicking a link in FB normally opens the link a new tab. But with CleanLink active the link opens in the current tab. Is this intended behaviour?

Cimbali commented 5 years ago

Ah, interesting. I think we intend to respect that but it's not always easy if we alter the link at click time (which is the only way we can show the yellow background feedback on the link).

Can you provide your platform and browser versions?

wyaqoob commented 5 years ago

Sure, thanks. Mac OS X 10.14.3, Firefox 66.0b13, and latest version of CleanLinks.

On 8 Mar 2019, at 02:05, Cimbali notifications@github.com wrote:

Ah, interesting. I think we intend to respect that but it's not always easy if we alter the link at click time (which is the only way we can show the yellow background feedback on the link).

Can you provide your platform and browser versions?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Cimbali/CleanLinks/issues/61#issuecomment-470775932, or mute the thread https://github.com/notifications/unsubscribe-auth/ABaO-x2LI0NX6eYdIVuB45xBuVPKyja8ks5vUcVsgaJpZM4bkZK-.

Cimbali commented 4 years ago

Can’t seem to reproduce for now, with Firefox 72 and the latest master. i’ll put this off until after the next release as it is a relatively minor issue.

Cimbali commented 4 years ago

Tested on macOS Firefox 73 and 74 with the latest Clean Links release, and facebook links open in new tab as expected. Please reopen if you can reproduce this bug specifying how.