search

Cimbali / CleanLinks

Converts obfuscated/nested links to genuine clean links.
https://addons.mozilla.org/en-GB/firefox/addon/clean-links-webext/
Mozilla Public License 2.0
76 stars 2 forks source link

target="_blank" is not honored #72

Closed BreadYogurt closed 5 years ago

BreadYogurt commented 5 years ago

Cleaned links with the target="_blank" tag are not opened in a new tab like they are supposed to. This happens regardless of whether the "Follow Target Attribute" setting is enabled or not.

Cimbali commented 5 years ago

Yes this has always been a tricky thing to recreate. This is because to get around the javascript events caused by a click on a link, we basically extract the url and then do the equivalent of pasting the URL in the address bar and pressing enter. That is, we use window.url = <cleaned link>. There is specific code to re-create the opening in a new tab however, but it is slightly tricky to do it properly.

Can you please specify browser and its version, the add-on version of CleanLinks and your configuration (basically which of the Features are selected).

BreadYogurt commented 5 years ago

My browser is Firefox v68.0.1, CleanLinks is v3.2.7, and here is my configuration: Screenshot from 2019-08-02 22-21-54