Cimbali / CleanLinks

Converts obfuscated/nested links to genuine clean links.
https://addons.mozilla.org/en-GB/firefox/addon/clean-links-webext/
Mozilla Public License 2.0
76 stars 2 forks source link

Stylistic improvements #87

Closed Cimbali closed 4 years ago

Cimbali commented 4 years ago

Possibly inspired from other similar add-ons, with small fonts and symbol-based buttons rather than text-based, with a tighter layout.

Cimbali commented 4 years ago

I’m looking at basing the buttons on the octicons. Not sure if the shield or list conveys the “whitelist/rules” better: list-1 list-check list-edit list-x shield-1 shield-check shield-edit shield-x

The buttons being for whitelist once / add to whitelist / remove from whitelist / edit whitelist.

Cimbali commented 4 years ago

Some changes are now in master. Currently the editing of rules looks like this:

WhatsApp Image 2020-03-21 at 23 47 07

The popup looks something like this when opened from the toolbar:

Screenshot_20200322_005319

And something like this when opened from the overflow menu:

Screenshot_20200322_005643


Here are what the preferences and popup respectively look like on Android and in French:

Basically less spacing and bigger buttons, more vertical layouts, the rule selector is rather small as it is edited as a popup.

Cimbali commented 4 years ago

Any feedback/suggestions welcome. As you can see the wider popup is useful to look at very long links (with wrapping for selected links). If that’s not desirable, maybe we can use a setting with the preferred popup size.

I think these blue and red backgrounds in the history list need to go as well.

Cimbali commented 4 years ago

Bit more subtle colours and marking of selected entry:

Screenshot_20200322_021847

Mike-Reddick commented 4 years ago

a optional dark theme, can be welcome, and a option to open settings in a new tab, open in new tab can be good to avoid need scroll plugin description page to reach the settings.

Rtizer-9 commented 4 years ago

I think redirections which are blocked are more visible in the red background like earlier (just like all pics here except last one) as compared to the current implementation of cross button.

One more thing: earlier entries were clickable but now it doesn't change color so it creates a confusion whether it's selected or not (for adding to whitelist etc)

Cimbali commented 4 years ago

Alright so some colouring is back, but a little more subtle than previously. Hopefully it both looks OK and is not too confusing now.