search

Cimpress-MCP / postal-codes-js

Provide postal code validation for javascript
Apache License 2.0
43 stars 36 forks source link

change VNM format rule from 6Digits to 5Digits #46

Closed tamonmon0417 closed 4 years ago

tamonmon0417 commented 4 years ago

Postal code rule of VNM has changed. Now they use 5Digits format for postal code! Please review it.

Ref. https://en.wikipedia.org/wiki/Postal_codes_in_Vietnam

tamonmon0417 commented 4 years ago

Could anyone review this PR please?

ozankaya commented 4 years ago

Can you please bump the minor version in the package.json and package-lock.json files so that this change publishes to npm automatically?

tamonmon0417 commented 4 years ago

Okay I'll change it from 2.2.5 to 2.3.0.

tamonmon0417 commented 4 years ago

I updated version in the package.json and package-lock.json

tamonmon0417 commented 4 years ago

@ozankaya May I know why current build is failed? https://github.com/Cimpress-MCP/postal-codes-js

ozankaya commented 4 years ago

@ozankaya May I know why current build is failed? https://github.com/Cimpress-MCP/postal-codes-js

https://github.com/Cimpress-MCP/postal-codes-js/pull/47