V3 - Githubissues

Cimpress-MCP / postal-codes-js

Provide postal code validation for javascript

Apache License 2.0

43 stars 36 forks source link

V3 #59

Open tomhooijenga opened 4 years ago

tomhooijenga commented 4 years ago

This PR is for #5. It also fixes #7 .

Updated packages
Updated docs
Added docs on how to contribute
Updated tests
- Test argument combinations
- Test postal code formats
- Test data combinations
Split data
- countries
- formats
- tests
- lookup
Unify data loading for web & node
Add extensible data lookup system
Returns true/false or throws, no strings

tomhooijenga commented 4 years ago

The checks are failing on node 6 and 8. Do we require support for them or can I just remove them from travis?

ozankaya commented 4 years ago

The checks are failing on node 6 and 8. Do we require support for them or can I just remove them from travis?

I think it's fine to drop node 6 & 8 support with the v3. The PR looks good to me. I pinged the other maintainers of the repository for a second review as this is a big change.

tomhooijenga commented 3 years ago

@ozankaya Do you happen to know if there's any progress on this?