search

Cimpress-MCP / vagrant-orchestrate

Cross platform deployment orchestration to existing managed servers using vagrant provisioners
Other
19 stars 13 forks source link

include windows guest directive on winrm template #45

Closed maclennann closed 9 years ago

maclennann commented 9 years ago

So Windows stops being detected as SuSE (and anything else that it might get detected as if it wasn't getting detected as SuSE).

edit: includes some rubocop appeasement

maclennann commented 9 years ago

All of the important acceptance tests fail, but I daresay it's not my fault:

Failures:

  1) vagrant orchestrate status handles no status file gracefully
     Failure/Error: Unable to find matching line from backtrace
       expected "You appear to be running Vagrant outside of the official installers.\nNote that the installers are what ensure that Vagrant has all required\ndependencies, and Vagrant assumes that these dependencies exist. By\nrunning outside of the installer environment, Vagrant may not function\nproperly. To remove this warning, install Vagrant using one of the\nofficial packages from vagrantup.com.\n" to include "Status unavailable."
       Diff:
       @@ -1,2 +1,7 @@
       -Status unavailable.
       +You appear to be running Vagrant outside of the official installers.
       +Note that the installers are what ensure that Vagrant has all required
       +dependencies, and Vagrant assumes that these dependencies exist. By
       +running outside of the installer environment, Vagrant may not function
       +properly. To remove this warning, install Vagrant using one of the
       +official packages from vagrantup.com.

     # acceptance/command/status_spec.rb:21:in `block (2 levels) in <top (required)>'

  2) vagrant orchestrate push strategies can push with carary_half_half strategy
     Failure/Error: Unable to find matching line from backtrace
       expected: >= 3
            got:    -12740528
     # acceptance/command/push_spec.rb:53:in `block (3 levels) in <top (required)>'

  3) vagrant orchestrate push strategies can push with half_half strategy
     Failure/Error: Unable to find matching line from backtrace
       expected: < 5
            got:   12740563
     # acceptance/command/push_spec.rb:71:in `ensure_datetimes_within'
     # acceptance/command/push_spec.rb:41:in `block (3 levels) in <top (required)>'

  4) vagrant orchestrate push strategies can push with carary strategy
     Failure/Error: Unable to find matching line from backtrace
       expected: < 5
            got:   12740591
     # acceptance/command/push_spec.rb:71:in `ensure_datetimes_within'
     # acceptance/command/push_spec.rb:31:in `block (3 levels) in <top (required)>'

  5) vagrant orchestrate push strategies can push in parallel
     Failure/Error: Unable to find matching line from backtrace
       expected: < 5
            got:   12740617
     # acceptance/command/push_spec.rb:71:in `ensure_datetimes_within'
     # acceptance/command/push_spec.rb:23:in `block (3 levels) in <top (required)>'

Finished in 2 minutes 42.6 seconds
10 examples, 5 failures
chrisbaldauf commented 9 years ago

LGTM! The acceptance test failures are almost surely from time skew. I'm a little confused why the shell script in the up for the local servers wouldn't cause the times to sync, but I'm not concerned, since the change that you made only impacts the init command.

maclennann commented 9 years ago

K. FWIW when I try to do the equivalent to the acceptance tests manually, I get.

/home/nmaclennan/.rvm/gems/ruby-2.1.5/bundler/gems/vagrant-1cd667b243f4/lib/vagrant/util/keypair.rb:14:in `initialize': BN lib (OpenSSL::PKey::RSAError)
    from /home/nmaclennan/.rvm/gems/ruby-2.1.5/bundler/gems/vagrant-1cd667b243f4/lib/vagrant/util/keypair.rb:14:in `new'
    from /home/nmaclennan/.rvm/gems/ruby-2.1.5/bundler/gems/vagrant-1cd667b243f4/lib/vagrant/util/keypair.rb:14:in `create'
    from /home/nmaclennan/.rvm/gems/ruby-2.1.5/bundler/gems/vagrant-1cd667b243f4/plugins/communicators/ssh/communicator.rb:163:in `ready?'
    from /home/nmaclennan/.rvm/gems/ruby-2.1.5/gems/vagrant-managed-servers-0.7.1/lib/vagrant-managed-servers/action/read_state.rb:43:in `read_state'
    from /home/nmaclennan/.rvm/gems/ruby-2.1.5/gems/vagrant-managed-servers-0.7.1/lib/vagrant-managed-servers/action/read_state.rb:15:in `call'
    from /home/nmaclennan/.rvm/gems/ruby-2.1.5/bundler/gems/vagrant-1cd667b243f4/lib/vagrant/action/warden.rb:34:in `call'
    from /home/nmaclennan/.rvm/gems/ruby-2.1.5/bundler/gems/vagrant-1cd667b243f4/lib/vagrant/action/builtin/config_validate.rb:25:in `call'