Closed aubertc closed 1 year ago
Can we access this flag non-interactively? Ideally, for this fix to be complete and tested, we should have test cases that check that with this hasSameProcess
/ the --process-names-equivalent
flag set to true, then P
and Q
are not equivalent, and that with that flag set to false, they are equivalent (or the other way around, sorry if I read that wrong).
Yes, in the main class we loop through the program args. Each arg is matched to a flag and then added to a static array which serves as the "global config". Its recommended to clear this array before and after each test so as to not interfere with other tests or be interfered by others
Closing for now, as it's assumed closed. Please reopen if you find an issue
As of now,
P
andQ
are seen as equivalent:https://github.com/CinRC/IRDC-CCSK/blob/50b2b777fb1902592a46794e62045a5307ddae1b/src/test/java/tests/SimulationTest.java#L151-L165
However, it could be useful to treat them as different, so that we could e.g. distinguish between
a.P + b.Q
anda.Q + b.P
, which would be now treated as equivalent, even if they should probably not be treated as such: at least, unless we know thatP
andQ
are themselves equivalent, we should not assume that.