search

CinRC / IRDC-CCSK

Java implementation of distributed reversible computation verification
https://spots.augusta.edu/caubert/cinrc/
GNU General Public License v3.0
4 stars 2 forks source link

Make "letter process" different #55

Closed aubertc closed 1 year ago

aubertc commented 1 year ago

As of now, P and Q are seen as equivalent:

https://github.com/CinRC/IRDC-CCSK/blob/50b2b777fb1902592a46794e62045a5307ddae1b/src/test/java/tests/SimulationTest.java#L151-L165

However, it could be useful to treat them as different, so that we could e.g. distinguish between a.P + b.Q and a.Q + b.P, which would be now treated as equivalent, even if they should probably not be treated as such: at least, unless we know that P and Q are themselves equivalent, we should not assume that.

aubertc commented 1 year ago

Can we access this flag non-interactively? Ideally, for this fix to be complete and tested, we should have test cases that check that with this hasSameProcess / the --process-names-equivalent flag set to true, then P and Q are not equivalent, and that with that flag set to false, they are equivalent (or the other way around, sorry if I read that wrong).

peterbro1 commented 1 year ago

Yes, in the main class we loop through the program args. Each arg is matched to a flag and then added to a static array which serves as the "global config". Its recommended to clear this array before and after each test so as to not interfere with other tests or be interfered by others

peterbro1 commented 1 year ago

Closing for now, as it's assumed closed. Please reopen if you find an issue