search

Cinderella-Man / hands-on-elixir-and-otp-cryptocurrency-trading-bot-source-code

Resources related to the "Hands-on Elixir & OTP: Cryptocurrency trading bot" book
https://elixircryptobot.com
75 stars 24 forks source link

Compilation error in chapter_15 after recent commit #5

Closed kamidev closed 3 years ago

kamidev commented 3 years ago

== Compilation error in file lib/binance_mock.ex == ** (CompileError) lib/binance_mock.ex:275: undefined function symbol/0

A recent commit removed the local variable "symbol". I changed "symbol" to "trade_event.symbol" to fix this.

Thanks a lot for your book and the great sample code!

Cinderella-Man commented 3 years ago

Hi :wave:

I'm really sorry for that - I was trying to simplify things (by updating the book/code to all uppercase topic names) and ended up breaking them :disappointed: Thank you very much for pointing out this issue :clap:

I updated 12 branches with the bugfix and released a new version of the book! :+1:

Thanks a lot for your book and the great sample code!

I hope it will get even better with time because of great contributors like :wink:

kamidev commented 3 years ago

Great! No need to apologize, this was basically a typo. I had a really good time running through your book chapter by chapter a few days ago. Working code and clean commits after each chapter made it easy to keep going and test things without getting stuck.