search

Cinderella-Man / hands-on-elixir-and-otp-cryptocurrency-trading-bot

Source code to generate the "Hands-on Elixir & OTP: Cryptocurrency trading bot" book
https://elixircryptobot.com
263 stars 34 forks source link

Possible typo in Chapter 5 supervision tree images? #30

Closed Fadhil closed 9 months ago

Fadhil commented 9 months ago

In chapter 5, where we see an diagram representing the supervision tree, it seems like there is an error in https://github.com/Cinderella-Man/hands-on-elixir-and-otp-cryptocurrency-trading-bot/tree/main/images/chapter_05_03_full.png,https://github.com/Cinderella-Man/hands-on-elixir-and-otp-cryptocurrency-trading-bot/tree/main/images/chapter_05_04_full.png and https://github.com/Cinderella-Man/hands-on-elixir-and-otp-cryptocurrency-trading-bot/tree/main/images/chapter_05_05_full.png, where the bottom most Naive.Leader should actually read Naive.Trader. Otherwise, I might be understanding this wrong.

Related images:

chapter_05_03_leader_added chapter_05_04_symbol_sup chapter_05_05_full

Cinderella-Man commented 9 months ago

Hello @Fadhil,

Thank you very much for raising this issue :pray: You are completely right and I'm truly surprised that nobody has pointed this out earlier - well done :+1: - I will fix this as soon as I will figure out what app I was using to create those :thinking:

Cinderella-Man commented 9 months ago

Thank you once again - I built a new version of the book, updated online and on Gumroad - feel free to raise any other issues that you would came across - the power of the community :muscle: :rocket: