search

Cinderella-Man / hands-on-elixir-and-otp-cryptocurrency-trading-bot

Source code to generate the "Hands-on Elixir & OTP: Cryptocurrency trading bot" book
https://elixircryptobot.com
263 stars 34 forks source link

Unused Decimal Alias on chapter 10 #32

Closed Bodhert closed 8 months ago

Bodhert commented 8 months ago

Hello! I love your book 💟 !!! awesome work!

I believe that alias Decimal in chapter 10. serve no purpose

Cinderella-Man commented 8 months ago

Hello @Bodhert :wave:

Apologies for so much lag in communication back to you. You are absolutely right - great attention to details :sunglasses:

Thank you very much for your kind words about the book as well :heart: I hope that the remaining chapters of the book will take your appreciation/Elixir skill to a whole new level :rocket: All the best and thank you once again for raising an issue!

PS. The aliasing "improvement" will become part of the book in the next release - I just made a change to the source of the 10th chapter to not forget about it! Thank you! :pray:

Bodhert commented 8 months ago

@Cinderella-Man chapter 11 has the same detail in /apps/streamer/priv/seed_settings.exs 🙈

Cinderella-Man commented 8 months ago

Thank you once again - I fixed the issue in the 11th chapter and fixed the code in the source code repo - you are officially a "contributor" to my Elixir book - much appreciated :pray:

Release